Repository navigation
Bump rand from 0.8.5 to 0.8.7 in /rust - #3
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [rand](https://github.com/rust-random/rand) from 0.8.5 to 0.8.7. - [Release notes](https://github.com/rust-random/rand/releases) - [Changelog](https://github.com/rust-random/rand/blob/0.8.7/CHANGELOG.md) - [Commits](rust-random/rand@0.8.5...0.8.7) --- updated-dependencies: - dependency-name: rand dependency-version: 0.8.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
UlysseCorbeil
pushed a commit
that referenced
this pull request
Oct 30, 2026
dump_result loaded a full uint256_t out of result.output_data whenever
output_size was non-zero. Context::copy_result_data allocates that buffer
with std::malloc(*size) for exactly the size the executed bytecode passes
to RETURN, so any RETURN of 1..31 bytes over-read the allocation by up to
31 bytes and hex-printed adjacent heap into the tool's JSON. The same
load silently truncated results longer than 32 bytes to their first word.
Hex-encode exactly output_size bytes instead, which fixes both.
Bytecode returning a single byte 0x2a, run three times before the fix:
$ printf '602a60005360016000f3' > ret1.hex
$ mce -r ret1.hex
{"result": "2a00099925560000000000000000000030306633000000006102000000000000"}
{"result": "2a46eb64be600000000000000000000030306633000000006102000000000000"}
{"result": "2a731c3e85600000000000000000000030306633000000006102000000000000"}
Only the leading 2a is the result; the other 31 bytes are adjacent heap
and differ per run. The recurring 30306633 is ASCII "00f3", the tail of
the input file's own hex text. After the fix that input prints
{"result": "2a"} on every run.
The truncation is the same defect from the other side - 64 returned
bytes rendered as one digit before the fix:
$ printf '60406000f3' > ret64.hex
$ mce -r ret64.hex
{"result": "0"}
and now prints all 128 hex digits.
Output format changes for results that are not exactly one word wide: a
32-byte RETURN of 42 renders as 64 zero-padded hex digits rather than
"2a". Nothing consumes this output - the only references to mce outside
its own sources are cmd/vm/mce/CMakeLists.txt and cmd/CMakeLists.txt.
category/vm/compiler/types.hpp is dropped alongside the two integer
headers; it was included only for its uint256_t alias, used solely on
the removed line.
Confirmed under gcc-asan. Before, on the one-byte return:
ERROR: AddressSanitizer: heap-buffer-overflow
READ of size 32 at 0x72602abe01f0
#3 dump_result cmd/vm/mce/mce.cpp:154
0x72602abe01f1 is located 0 bytes after 1-byte region
allocated by:
#1 Context::copy_result_data category/vm/runtime/context.cpp:208
After: no overflow on returns of 0, 1, 32 or 64 bytes.
The pre-existing heap-use-after-free at mce_main scope exit - Binary bin
is declared before asmjit::JitRuntime rt, so rt is destroyed first and
bin's shared_ptr<Nativecode> releases into the freed JitAllocator - is
left untouched for a separate change.
Raised as EXEC-063 in the mythos-review audit batch (EXE-150).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rand from 0.8.5 to 0.8.7.
Changelog
Sourced from rand's changelog.
Commits
90ff85erand v0.8.7: backport #1790 (#1804)5309f250.8.6 (#1772): update for recent nightly rustc and backport #17641126d03When testing rustc 1.36, use compatible dependencies.143b602Add Cargo.lock.msrv.9be86f2Fix cross build test.5e0d50dDrop simd_support.8ff02f0Upgrade cache action.4ad0cc3Don't test for unsupported target architecture.258e6d0Address warning.9f0e676Mark some internal traits as potentially unused.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.