Repository navigation
Bump to nitro v3.12.2 - #33
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Update 3.12.x relese notes
A panic inside SequenceDelayedMessage escaped StartSequencing and killed the sequencing thread. The delayed turn now recovers the panic, logs it with a backtrace, and throttles delayed sequencing for one minute, leaving regular turns unaffected. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The panic can only originate inside SequenceDelayedMessage, before the named result is assigned, so it is already nil in the deferred function. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
backport 3.12: fix for head truncation below a diverged tail group
…ort-3.12 Recover from panics while sequencing delayed messages (backport OffchainLabs#1005)
Add cmd/transaction-feed-client, a single-file Go executable that connects to the transaction feed WebSocket, decodes each JSON message, and prints a summary line per transaction. It depends only on the standard library and github.com/coder/websocket so the file can be copied into any Go module. The client takes the feed address and an optional Bearer token as flags, supports wss:// through the default TLS stack, disables the 32 KiB read limit so large transactions are not rejected, and reconnects after a disconnect. Wire the binary into `make build` and add the changelog entry. Closes NIT-5612
Feed consumers that wait for every transaction of a PGA round before
acting could only infer that a round had ended when the first message of
the next round arrived, which wasted the next round's bidding window.
Bump the feed to version 2. Every message now starts with an envelope of
version, kind, timestamp_ms, and pga_round. The transaction payload is
unchanged under kind "Transaction". The new kind "RoundEnd" carries
block_number and marks the end of a group of transactions whose order
was decided together. Consumers should ignore kinds they don't know, so
this change is forward-compatible.
A PGA round with one transaction produces:
{"version":2,"kind":"Transaction","timestamp_ms":1759795200000,
"pga_round":3,"transaction":{"block_number":1234,"tx_index":1,
"raw_tx":"0x02f8...","tx_hash":"0xab...","receipt":{...}}}
{"version":2,"kind":"RoundEnd","timestamp_ms":1759795200012,
"pga_round":3,"block_number":1234}
Under FIFO ordering, and for resequenced and delayed-message blocks,
pga_round is omitted and a single RoundEnd follows the block's
transactions.
The demo client dispatches on kind and still accepts version 1 messages,
to ease migration. Existing consumers must handle version 2 and the new
kind before the sequencer upgrades.
Closes NIT-5927
Feed consumers that wait for every transaction of a PGA round before
acting could only infer that a round had ended when the first message of
the next round arrived, which wasted the next round's bidding window.
Bump the feed to version 2. Every message now starts with an envelope of
version, kind, timestamp_ms, and pga_round. The transaction payload is
unchanged under kind "Transaction". The new kind "PGARoundEnd" carries
block_number and marks the end of a PGA round. Consumers should ignore
kinds they don't know, so this change is forward-compatible.
A PGA round with one transaction produces:
{"version":2,"kind":"Transaction","timestamp_ms":1759795200000,
"pga_round":3,"transaction":{"block_number":1234,"tx_index":1,
"raw_tx":"0x02f8...","tx_hash":"0xab...","receipt":{...}}}
{"version":2,"kind":"PGARoundEnd","timestamp_ms":1759795200012,
"pga_round":3,"block_number":1234}
The PGA orderer sends it through the feed broadcaster the sequencer hands
it, from recordRoundEnd and before the wait for the next round, so empty
rounds are signalled too. FIFO ordering, delayed-message blocks, and
resequenced blocks have no rounds and send nothing new.
The demo client dispatches on kind and still accepts version 1 messages,
to ease migration. Existing consumers must handle version 2 and the new
kind before the sequencer upgrades.
Closes NIT-5927
…065-transaction-feed-client Backport transaction-feed client example
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Add v3.12.2 changelog
Nitro never builds block access lists, so repair can reset a bals table that lags after a 3.11.x run instead of truncating the chain to it.
…ort-3.12 Keep recent blocks when returning to 3.12.x after 3.11.x (backport OffchainLabs#1110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream tag
v3.12.2. Files outside our own changes are identical tov3.12.2, and the Firehose delta against upstream is the same 41 files as in v3.12.1-fh3.0.go-ethereumsubmodule points at1927c192f0, the head of Bump to the go-ethereum revision of nitro v3.12.2 go-ethereum#75 (go-ethereum revision30456d24d3pinned by nitro v3.12.2). The submodule was the only merge conflict.ACTIVATIONS.mdstatuses refreshed. v3.12.2 adds no ArbOS version, precompile, transaction type or balance reason. One, Nova and Sepolia are all at ArbOS 61, with no upgrade scheduled.v3.12.2-fh3.0, on this PR's merge commit. That is the rule's result (newest tagv3.11.4-fh3.0-1→ upstream version replaced,-Ndropped) and matches the planned tag.fh3.0is unchanged because the block model does not change.Merge order
go-ethereumsubmodule and the commit link inCHANGELOG.sf.mdto Pull out Sequencer from ArbInterface and add TxForwarder mode OffchainLabs/nitro#75's merge commit, as done for v3.12.1. If Pull out Sequencer from ArbInterface and add TxForwarder mode OffchainLabs/nitro#75 lands as a fast-forward ofrelease/arbitrum-3.xto1927c192f0, nothing needs to change. Until Pull out Sequencer from ArbInterface and add TxForwarder mode OffchainLabs/nitro#75 is merged, this PR pins a commit that exists only on the go-ethereum bump branch.CHANGELOG
This also renames the
## Unreleasedheading above the v3.12.1 entries to## v3.12.1-fh3.0. Thev3.12.1-fh3.0tag was pushed on the bump branch's "Release v3.12.1-fh3.0" commit (def4eda70), which never reachedrelease/v3.x-fh. For the same reason,git describeon the release branch still reportsv3.11.4-fh3.0-1.Firehose review
Upstream range
v3.12.1..v3.12.2(13 non-merge commits): sequencer panic recovery for delayed messages, a transaction-feed demo client and feed round markers, changelog files, thebalsfreezer table marked optional ingethhook, and the go-ethereum pin. The go-ethereum range5eee8f546e..30456d24d3only touchescore/rawdb.recover()inSequencer.sequenceDelayedMessageonly runs on a sequencer. A traced sequencer that panics mid-block would retry with the tracer still holding the open block, but Firehose readers do not sequence.MaxArbosVersionSupportedstays 61) and no fork-gated change. SeeACTIVATIONS.md.core/typesis unchanged in go-ethereum and no Arbitrum type changed in nitro.Test Execution Summary
Build Status
go build ./...: PASSEDmake build-node-depsthengo build ./...: PASSEDgo vet ./arbos/... ./execution/... ./precompiles/... ./gethhook/... ./arbnode/...: PASSEDdocker build --target nitro-node -f Dockerfile ., thendocker build -f Dockerfile.sf --build-arg NITRO_BASE_IMAGE=<that image> .: PASSED. The image runsnitro --versionand lists the--execution.vmtrace.*flags. It bundles fireeth v2.24.1.Unit Tests
go test ./core/... ./eth/...eth/tracersandeth/tracers/internal/tracetest/firehosego test ./execution/gethexec/... ./gethhook/... ./arbos/...Integration Tests
system_testswere not run, because Firehose code lives in go-ethereum and nitro's Firehose diff is build and release files only.Battlefield Tests
879ea9a, fireeth v2.24.1, plaingethbuilt from Bump to the go-ethereum revision of nitro v3.12.2 go-ethereum#75 (nonitrobinary).GETH_BINARY=<geth> ./scripts/run_firehose_geth_dev.sh 3.0 prague, thenpnpm test:fh3.0:geth-dev: 72 passing, 11 failing, 21 pending.GETH_BINARY=<geth> ./scripts/run_firehose_geth_dev.sh 3.0(cancun), thenpnpm test:fh3.0:geth-dev: 71 passing, 9 failing, 24 pending (a subset of the same diffs).d3459f8e99, the go-ethereum commit in v3.12.1-fh3.0. It gives the same 11 failures, and the diff output is byte-for-byte identical. This merge changes no Battlefield output.gasConsumed, transactiongasUsedand the matchingREASON_GAS_REFUNDvalue are 2,500 higher than in the canonical geth-dev snapshot (plus the derivedgasLimitof one nested call). The trace shape is identical. Value diff, root cause not investigated (2,500 is the difference between a cold and a warm account access).keccakPreimagesentries are missing compared with the canonical snapshot (hashed log arguments, and hash-of-hash entries that explain no changed slot). Expected: since v3.11.4-fh3.0, this fork keeps only preimages that explain a changed storage slot.pnpm test:fh2.3:arbitrum-geth-dev, the Arbitrum target the runbook names, no longer runs. It expects Firehose block version 3, and this fork emits version 5 since v3.12.1-fh3.0. The previous bump PR reported 0 failures fortest:fh3.0:geth-dev; that run's setup is unknown, so the gap is unexplained.test:fh3.0:nitro-devhas no snapshots.Open questions
1927c192f0) because Pull out Sequencer from ArbInterface and add TxForwarder mode OffchainLabs/nitro#75 is not merged yet. Conservative choice: keep that pin and repoint it to Pull out Sequencer from ArbInterface and add TxForwarder mode OffchainLabs/nitro#75's merge commit before merging, as in the merge order above.fh2.3:arbitrum-geth-devsnapshots are obsolete since the switch to block version 5, andfh3.0:geth-devhas 11 standing diffs on this line (identical before and after this bump). Conservative choice: report them as pre-existing and change no snapshots. Someone should decide whether to recordfh3.0/v5/arbitrum-geth-devoverrides.