Repository navigation
Stop proofs ExEx from printing Firehose blocks - #31
Merged
sduchesneau merged 1 commit intoNov 10, 2026
Merged
Conversation
The proofs engine re-executes blocks reth already imported and traced. Through the Firehose executor's `execute`, each of them was printed a second time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor fix, since we do not use
--proofs-historyin production, but it is a low-cost correctness fix to prevent issues further down.With
--proofs-history, the proofs engine re-executes blocks reth already imported, through the node's EVM config. That is the Firehose executor, whoseexecutetraces, so each re-executed block was printed as a secondFIRE BLOCK(catch-up, blocks without precomputed trie data, verification-interval blocks).The engine now calls
execute_one, which runs the block without tracing. A new test inop-reth/crates/trie/tests/live.rsruns the proofs engine with a Firehose EVM config and checks that noFIRE BLOCKis printed; it fails without the fix.