Skip to content

Stop proofs ExEx from printing Firehose blocks - #31

Merged
sduchesneau merged 1 commit into
release/op-reth-2.xfrom
fix/proofs-exex-firehose-duplicates
Nov 10, 2026
Merged

sduchesneau merged 1 commit into
release/op-reth-2.xfrom
fix/proofs-exex-firehose-duplicates

Conversation

@sduchesneau

@sduchesneau sduchesneau commented Nov 10, 2026 •

Copy link
Copy Markdown

This is a minor fix, since we do not use --proofs-history in production, but it is a low-cost correctness fix to prevent issues further down.

With --proofs-history, the proofs engine re-executes blocks reth already imported, through the node's EVM config. That is the Firehose executor, whose execute traces, so each re-executed block was printed as a second FIRE BLOCK (catch-up, blocks without precomputed trie data, verification-interval blocks).

The engine now calls execute_one, which runs the block without tracing. A new test in op-reth/crates/trie/tests/live.rs runs the proofs engine with a Firehose EVM config and checks that no FIRE BLOCK is printed; it fails without the fix.

The proofs engine re-executes blocks reth already imported and traced. Through the Firehose executor's `execute`, each of them was printed a second time.
@sduchesneau
sduchesneau marked this pull request as ready for review November 10, 2026 21:50
@sduchesneau
sduchesneau merged commit 9f75a6b into release/op-reth-2.x Nov 10, 2026
2 checks passed
@dfuse-bot dfuse-bot mentioned this pull request Nov 16, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant