Repository navigation
chore(firehose): clear workspace clippy and doc lints - #102
Merged
Merged
Conversation
No behavior change. This applies the workspace lints that reth-firehose and reth-firehose-tests opt into: const fn where clippy asks for it, Self:: in impls, backticks in docs, bool::then, next_back, &Path instead of &PathBuf. One test doc comment still named the StreamingFast alloy-evm fork, which no longer exists, so it now names evm2's system-call inspection. It also applies cargo +nightly fmt to the BAL Firehose tests in reth-engine-tree.
maoueh
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes no behavior change. On
release/reth-2.x,cargo clippy -p reth-firehose -p reth-firehose-tests --all-targets -- -D warningsfails on these lints. This PR fixes them, so that command passes.crates/firehose/src/lib.rs:SynchronizedStdout::newis aconst fn.crates/firehose/src/mapper.rs: backticks in docs,Self::Legacyin theSignatureFieldsimpl,bool::thenformax_fee_per_gas, and nocloneof aU256.crates/firehose/src/prelude.rs: backticks in docs.crates/firehose-tests/src/prestate.rs:next_backinstead oflaston a double-ended iterator.crates/firehose-tests/tests/prestate.rs:&Pathinstead of&PathBuf. One doc comment still named the StreamingFastalloy-evmfork, which no longer exists. It now says that evm2 routes system calls to the inspector once system-call inspection is on.It also applies
cargo +nightly fmtto one test incrates/engine/tree/src/tree/payload_processor/bal/firehose.rs. After this PR,cargo +nightly fmt --all --checkis clean.Evidence: clippy as above passes with no allowed lints, and all
reth-firehoseandreth-firehose-teststests pass.Not in this PR: clippy on
reth-engine-treestill reportstype_repetition_in_boundsfor the separateEvm: reth_firehose::FirehoseLiveHooksbounds andneedless_pass_by_ref_mutforexecute_and_trace_block'shandleinpayload_validator.rs. I left them alone, because the separate bound lines look like they keep merges from upstream small. Theunused_mutincrates/rpc/rpc/src/debug.rsis upstream code.