Skip to content

chore(firehose): clear workspace clippy and doc lints - #102

Merged
maoueh merged 1 commit into
streamingfast:release/reth-2.xfrom
valvecitydev:sf/lint
Nov 12, 2026
Merged

maoueh merged 1 commit into
streamingfast:release/reth-2.xfrom
valvecitydev:sf/lint

Conversation

@valvecitydev

Copy link
Copy Markdown

This PR makes no behavior change. On release/reth-2.x, cargo clippy -p reth-firehose -p reth-firehose-tests --all-targets -- -D warnings fails on these lints. This PR fixes them, so that command passes.

  • crates/firehose/src/lib.rs: SynchronizedStdout::new is a const fn.
  • crates/firehose/src/mapper.rs: backticks in docs, Self::Legacy in the SignatureFields impl, bool::then for max_fee_per_gas, and no clone of a U256.
  • crates/firehose/src/prelude.rs: backticks in docs.
  • crates/firehose-tests/src/prestate.rs: next_back instead of last on a double-ended iterator.
  • crates/firehose-tests/tests/prestate.rs: &Path instead of &PathBuf. One doc comment still named the StreamingFast alloy-evm fork, which no longer exists. It now says that evm2 routes system calls to the inspector once system-call inspection is on.

It also applies cargo +nightly fmt to one test in crates/engine/tree/src/tree/payload_processor/bal/firehose.rs. After this PR, cargo +nightly fmt --all --check is clean.

Evidence: clippy as above passes with no allowed lints, and all reth-firehose and reth-firehose-tests tests pass.

Not in this PR: clippy on reth-engine-tree still reports type_repetition_in_bounds for the separate Evm: reth_firehose::FirehoseLiveHooks bounds and needless_pass_by_ref_mut for execute_and_trace_block's handle in payload_validator.rs. I left them alone, because the separate bound lines look like they keep merges from upstream small. The unused_mut in crates/rpc/rpc/src/debug.rs is upstream code.

No behavior change. This applies the workspace lints that
reth-firehose and reth-firehose-tests opt into: const fn where clippy
asks for it, Self:: in impls, backticks in docs, bool::then, next_back,
&Path instead of &PathBuf. One test doc comment still named the
StreamingFast alloy-evm fork, which no longer exists, so it now names
evm2's system-call inspection. It also applies cargo +nightly fmt to
the BAL Firehose tests in reth-engine-tree.
@dfuse-bot
dfuse-bot requested a review from billettc November 12, 2026 01:12
@maoueh
maoueh merged commit 74d0f0e into streamingfast:release/reth-2.x Nov 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants