Skip to content

sider,layout: render from layout state - #6359

Open
wesrupert wants to merge 2 commits into
feat/sider/pr/6from
feat/sider/pr/7
Open

wesrupert wants to merge 2 commits into
feat/sider/pr/6from
feat/sider/pr/7

Conversation

@wesrupert

@wesrupert wesrupert commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Replace hard-coded Multichat in the sider with layout-driven elements.
  • Only render when the sider has something to show. Multichat doesn't count on platforms that don't support it, so a sider holding only Multichat stays hidden; alongside other elements it shows the "not supported" message.
  • Multichat is selectable in the layout editor now that placing it in the main grid empties the sider instead of mounting chat twice.

QA Instructions

  • N/A

@wesrupert
wesrupert added this pull request to stack #6363 October 29, 2026 23:02
@bundlemon

bundlemon Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

BundleMon

Files updated (1)
Status Path Size Limits
✅ renderer.(hash).js
10.79MB (+19.78KB +0.18%) -
Unchanged files (3)
Status Path Size Limits
✅ vendors~renderer.(hash).js
4.65MB -
✅ updater.js
115.29KB -
✅ guest-api.js
40.23KB -

Total files change +19.78KB +0.12%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@wesrupert
wesrupert marked this pull request as ready for review October 30, 2026 00:24
Copilot AI balanced review requested due to automatic review settings October 30, 2026 00:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Active issues cause guest-mode and stream-start flows to hide non-chat controls, divider resizing to reload docked websites, and moving chat to the main grid to leave no way to return it to the dock.

4 open issues
What changed in this PR

This PR makes the Streamlabs Desktop sider render elements from the current tab’s layout instead of always mounting Multichat.

Changes:

  • Render single or stacked dock elements, with a resizable split.
  • Determine dock visibility and minimum width from its assigned elements.
  • Enable Multichat placement in the layout editor without mounting duplicate chat instances.
File Description
app/​components-react/​windows/​Main.tsx Integrates layout-driven dock rendering, visibility, and minimum width.
app/​components-react/​root/​Dock.tsx Adds single and stacked dock rendering with persisted resizing.
app/​components-react/​root/​Dock.m.less Styles dock containers and stacked element spacing.
app/​components-react/​pages/​layout-editor/​SideBar.tsx Makes Multichat selectable in the layout editor.
app/​components-react/​editor/​renderLayoutElements.tsx Exposes element minimum sizes for dock sizing.

Review effort: Balanced

Comment thread app/components-react/root/Dock.tsx Resolved
Comment thread app/components-react/windows/Main.tsx Resolved
Comment thread app/components-react/windows/Main.tsx Resolved
Copilot AI balanced review requested due to automatic review settings November 2, 2026 22:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The sidebar memo can retain outdated Multichat support when settings change, and the new logged-out message lacks a translation dictionary entry.

2 open issues
4 resolved since last review

Review effort: Balanced

Comment thread app/components-react/windows/Main.tsx Resolved
Copilot AI balanced review requested due to automatic review settings November 2, 2026 23:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Concrete QA checks are missing for the visible layout, chat availability, and resizing behavior changes, including key grid, dock, platform, and persistence scenarios.

3 open issues

Review effort: Balanced

Comment thread app/components-react/windows/Main.tsx Resolved
Copilot AI balanced review requested due to automatic review settings November 3, 2026 00:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unrelated main-grid edits can recreate a docked BrowserView and lose its page state, and the QA instructions lack actionable checks for the layout and resizing changes.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread app/components-react/root/Dock.tsx Resolved
- Replace hard-coded Multichat in the dock with layout-driven elements
- Only render when the dock has something to show. Multichat doesn't
  count on platforms that don't support it, so a dock holding only
  Multichat stays hidden; alongside other elements it shows the "not
  supported" message.
- Multichat is selectable in the layout editor now that placing it in
  the main grid empties the dock instead of mounting chat twice.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants