Repository navigation
Conversation
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +19.78KB +0.12% Final result: ✅ View report in BundleMon website ➡️ |
wesrupert
force-pushed
the
feat/sider/pr/7
branch
from
October 30, 2026 00:10
caa3834 to
d11fc96
Compare
wesrupert
marked this pull request as ready for review
October 30, 2026 00:24
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Active issues cause guest-mode and stream-start flows to hide non-chat controls, divider resizing to reload docked websites, and moving chat to the main grid to leave no way to return it to the dock.
4 open issues
What changed in this PR
This PR makes the Streamlabs Desktop sider render elements from the current tab’s layout instead of always mounting Multichat.
Changes:
- Render single or stacked dock elements, with a resizable split.
- Determine dock visibility and minimum width from its assigned elements.
- Enable Multichat placement in the layout editor without mounting duplicate chat instances.
| File | Description |
|---|---|
app/components-react/windows/Main.tsx |
Integrates layout-driven dock rendering, visibility, and minimum width. |
app/components-react/root/Dock.tsx |
Adds single and stacked dock rendering with persisted resizing. |
app/components-react/root/Dock.m.less |
Styles dock containers and stacked element spacing. |
app/components-react/pages/layout-editor/SideBar.tsx |
Makes Multichat selectable in the layout editor. |
app/components-react/editor/renderLayoutElements.tsx |
Exposes element minimum sizes for dock sizing. |
Review effort: Balanced
wesrupert
force-pushed
the
feat/sider/pr/7
branch
from
November 2, 2026 22:24
d11fc96 to
f453bfd
Compare
gettinToasty
approved these changes
Nov 2, 2026
wesrupert
force-pushed
the
feat/sider/pr/7
branch
from
November 2, 2026 23:16
f453bfd to
24be431
Compare
wesrupert
force-pushed
the
feat/sider/pr/7
branch
from
November 3, 2026 00:00
24be431 to
03b8c8a
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unrelated main-grid edits can recreate a docked BrowserView and lose its page state, and the QA instructions lack actionable checks for the layout and resizing changes.
1 open issue
3 resolved since last review
Review effort: Balanced
- Replace hard-coded Multichat in the dock with layout-driven elements - Only render when the dock has something to show. Multichat doesn't count on platforms that don't support it, so a dock holding only Multichat stays hidden; alongside other elements it shows the "not supported" message. - Multichat is selectable in the layout editor now that placing it in the main grid empties the dock instead of mounting chat twice.
wesrupert
force-pushed
the
feat/sider/pr/7
branch
from
November 3, 2026 18:10
03b8c8a to
a1af8da
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
QA Instructions