Repository navigation
Bump obs-browser: skip CEF init while the cache lock is held - #789
Merged
Merged
Conversation
Picks up streamlabs/obs-browser#59: a leftover obs64 holding the CEF profile lock no longer crashes the next launch at startup. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Missing submodule revisions and diff prevent verification of the exact bump and change scope, while the Windows/CEF 6613 two-instance runtime test remains unrun.
No open issues 🎉
What changed in this PR
Bumps obs-browser to incorporate streamlabs/obs-browser#59, intended to prevent startup crashes when another OBS process holds CEF’s cache lock.
Changes:
- Adopts a safeguard that skips CEF initialization while the lock is held, disabling browser sources for the session instead of crashing.
| File | Description |
|---|
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A leftover obs64 holding CEF 6613's profile lock made the next obs64 crash at startup (Sentry
content::ContentMainRunnerImpl::Shutdown).obs-browser now skips CEF init in that case, so browser sources are disabled for the session instead of crashing.
Bumps obs-browser for streamlabs/obs-browser#59.