Skip to content

Tidy the club header, back links and sign-in page - #45

Merged
stretch0 merged 5 commits into
mainfrom
club-header-tidy
Oct 31, 2026
Merged

stretch0 merged 5 commits into
mainfrom
club-header-tidy

Conversation

@stretch0

@stretch0 stretch0 commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Club page header: Manage now sits on the same row as "← Clubs", as a smaller button. The logo and name are centred on each other, and the name has the full width, so "Regent's Park Runners" fits on one line at phone width. Before, Manage was pinned to the top while the logo was centred against a two-line name, so the three were at different heights.
  • Clubs list: "Join with a code" is folded into a small "Have a code? Join a club" link, which opens the form with the input focused. People with no clubs still see the form straight away. Most people join from an invite link; the code is for reading out at the start of a run.
  • Back links: the "←" character sat low against the text. A shared BackLink now draws the arrow as an icon, centred on the label, on all six pages that have one.
  • The code input's placeholder is no longer forced to capitals ("E.G. K7MPQ2RX").
  • Sign-in page scrolling: full-height pages use min-h-svh instead of min-h-dvh. On Firefox for Android with the address bar at the bottom, dvh can resolve to the height with the toolbar hidden, so the sign-in page scrolled by the toolbar's height even though nothing overflowed. svh is the height with the toolbar showing, so it always fits. The bottom nav is fixed, so the app layout is unaffected.
  • Sign out: the button now says "Signing out…" and shows why it failed instead of failing silently. Better Auth returns errors rather than throwing, so a failed sign-out used to look like nothing happened.

Checks

  • web lint, typecheck, unit tests and build pass; e2e: 12 passed.
  • Checked in a local demo instance at phone width in dark mode. The scroll couldn't be reproduced in desktop Chromium, so the sign-in fix still needs checking on the phone.

🤖 Generated with Claude Code

Andrew McCallum and others added 2 commits October 31, 2026 12:36
On the club page, Manage moves up beside "← Clubs", so the logo and
name line up and the name has room for one line. On the clubs list,
"Join with a code" becomes a small link unless you have no clubs yet,
since most people join through an invite link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
min-h-dvh can resolve to the height with the browser's toolbar hidden
(Firefox on Android with the address bar at the bottom), which made the
sign-in page scroll by the toolbar's height. svh always fits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stretch0 stretch0 changed the title Tidy the club header and fold away joining by code Tidy the club header, fold away joining by code, stop the sign-in page scrolling Oct 31, 2026
The "←" character sits low against the text in most fonts. A shared
BackLink draws the arrow as an icon, centred on the label, on every page
that has one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stretch0 stretch0 changed the title Tidy the club header, fold away joining by code, stop the sign-in page scrolling Tidy the club header, back links and sign-in page Oct 31, 2026
Andrew McCallum and others added 2 commits October 31, 2026 13:05
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signing out failed silently: Better Auth returns errors rather than
throwing, and nothing on screen changed either way. The button now says
"Signing out…" and shows why it failed, including a wrong ORIGIN.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stretch0
stretch0 merged commit 9b4b8ad into main Oct 31, 2026
5 checks passed
@stretch0
stretch0 deleted the club-header-tidy branch October 31, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant