Repository navigation
Remove synced runs that intervals.icu now lists as another sport - #46
Merged
Merged
Conversation
Sync only ever added runs, so a ride the watch recorded as a run stayed in openRun after being corrected in Garmin or intervals.icu, and its "best efforts" skewed the race predictions. Other sports are never imported, so a run that intervals.icu now calls something else is removed as if it had never been a run: its best efforts, original file and club shares go too. Forgetting it means it's imported again if it turns back into a run. Uploads and runs deleted by hand are untouched. The sync log counts removals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sync only ever added runs. A ride the watch recorded as a run stayed in openRun after it was corrected in Garmin or intervals.icu, and its "best efforts" (a 4:32 mile at 110 bpm and no cadence) set the race predictions.
What changed
Ride, say), is removed, matching how other sports are handled: they're never imported.0009_sync_removedaddsintegration_sync.removed.Note
PR 15 (intervals.icu OAuth) also adds a migration numbered 0009. Whichever merges second needs its migration regenerated as 0010.
Checks
Rideis removed with its shares, best efforts and file; a second sync removes nothing; turning it back into aRunre-imports it; a run deleted by hand stays deleted; an upload is untouched.db-migrations:checkpasses; e2e: 12 passed.🤖 Generated with Claude Code