Conversation
The baseline it compiles comes from the registry, and 4.0.0 is the first published version whose feature set builds: every earlier one rejected having both JWT backends on, which is what the check enables. Verified against the new baseline: 223 checks, all pass. Closes #84
The injected-verifier snippet still asked for 3.x, while the API it illustrates (`with_token_verifier`) only exists from 4.0.0 on. docs.rs renders this README as the crate's landing page, so the example a reader copies first resolved to a version without the method around it. Closes #87
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe README dependency example now targets version 4. The release-plz configuration no longer disables semantic version checks. ChangesRelease updates
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other · Severity of issue fixed: Medium 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Summary
Two loose ends from the 4.0.0 release, both scoped to the release machinery rather than the crate itself.
Re-enable the semver check (#84).
cargo-semver-checkscompiles the baseline from crates.io, and every version up to 3.0.2 rejects the feature set it uses (both JWT backends at once), so the check could not pass no matter what the working tree looked like. #85 shipped the fix; 4.0.0 is the first published version whose baseline builds, so thesemver_check = falseescape hatch has done its job and comes out.Pin the README example (#87). The injected-verifier snippet asked for
version = "3"while illustratingwith_token_verifier, which only exists from 4.0.0. docs.rs renders this README as the crate's landing page, so the first snippet a reader copies resolved to a version without the method the surrounding prose describes.Testing
The baseline now compiles under the heuristic feature set, which is exactly what failed before #85. No crate code changed in this PR.
Closes #84
Closes #87