Skip to content

Fix release, comparison and session reliability - #32

Merged
stuartd merged 3 commits into
mainfrom
codex/issue-29-reliability
Oct 7, 2026
Merged

stuartd merged 3 commits into
mainfrom
codex/issue-29-reliability

Conversation

@stuartd

@stuartd stuartd commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Fixes #29.

This addresses all seven review findings. Tagged builds now use one release workflow and share version validation/package names with the release script. Line matching has explicit memory/work budgets with a deterministic fallback that preserves source text and line numbers.

Explorer requests retain identity through file reading and publication: a slow request cannot overwrite a newer pair or compare against a different capture. File opening runs off the UI thread, and privacy clearing during the external-viewer warning prevents both export and built-in fallback. Pipe receipt accepts bounded concurrent messages, times out incomplete clients, acknowledges delivery, and continues while file handlers run.

Live owner leases protect external comparison files across sessions. Shared Explorer registration claims preserve surviving owners and reconcile contention on later updates/menu opening. Startup and Explorer share quoted application commands, including dotnet host + entry assembly. Viewer-setting and acknowledgement save failures now give feedback. The spec and Windows verification checklist describe the new limits and lifecycle behavior.

Validation:

  • Windows CI passed on the final commit: 96 core tests, 216 Windows tests, native Shell integration tests, regular/prerelease version propagation checks, and both validated package variants.
  • Portable policy/IPC regressions also passed locally, covering reversed file reads, warning invalidation, partial/slow pipe clients, and concurrent ownership/lock contention.
  • Windows application cross-build with the single-file analyzer enabled passes with zero warnings/errors.
  • Real desktop warning-loop and concurrent Windows-session checks remain manual and are documented in README/SPEC; keep the PR draft pending those checks.

@stuartd
stuartd marked this pull request as ready for review October 7, 2026 21:32
@stuartd
stuartd merged commit e437293 into main Oct 7, 2026
2 checks passed
@stuartd
stuartd deleted the codex/issue-29-reliability branch October 7, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address full code review findings: release workflow, diff memory, comparison races and reliability

1 participant