ci: run typecheck, tests and builds from a root workflow - #7
Merged
Merged
Conversation
The ci.yml files under packages/*/.github (and example/.github in scorm) were never executed: GitHub Actions only reads .github/workflows from the repository root. They were leftovers from when those directories were standalone repos, so typecheck, tests and builds had no CI coverage at all — only the Angular smoke test ran. Consolidate them into a single root workflow across Node 20 and 22. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011kohSPc6KNpFd9EiV8Vbez
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
package-lock.json was generated on macOS and carries the installable entry for @rolldown/binding-darwin-arm64 but not the linux-x64-gnu one (npm/cli#4828). On a Linux runner `npm ci` therefore leaves vitest without its native rolldown binding and every test file fails to load with MODULE_NOT_FOUND. Mirror the workaround angular-smoke.yml already uses. This is temporary: the pnpm migration drops it, since pnpm records every platform variant in the lockfile and filters at install time. xapi's lockfile happens to carry both entries, which is why only this repo is affected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011kohSPc6KNpFd9EiV8Vbez
…h on Node 22 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011kohSPc6KNpFd9EiV8Vbez
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011kohSPc6KNpFd9EiV8Vbez
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ci.ymlfiles underpackages/scorm/.github/andexample/.github/were never executed: GitHub Actions only reads.github/workflowsfrom the repository root. They were leftovers from when those directories were standalone repos, which means typecheck, tests and builds have had no CI coverage at all — only the Angular smoke test ran.This consolidates them into a single root workflow (Node 20 and 22) and deletes the inert ones.
Groundwork for the upcoming npm → pnpm migration: the CI is introduced here, still on npm, so that any pre-existing failure surfaces now and isn't mistaken for a pnpm regression later.
Test plan
angular-smokestill passes🤖 Generated with Claude Code
https://claude.ai/code/session_011kohSPc6KNpFd9EiV8Vbez