Repository navigation
fix: prevent 500 errors from missing logger level check - #426
Closed
zaixiakongyiji wants to merge 1 commit into
Closed
zaixiakongyiji wants to merge 1 commit into
zaixiakongyiji wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Requests that reached
normalize_gemini_request()failed with HTTP 500 because the customLoggerimplementation did not provide theis_enabled_for()method used by the converter.Fix
Add
Logger.is_enabled_for()with the same level-threshold semantics as the existing logger, while preserving the debug log guard innormalize_gemini_request().Validation
python -m compileall -q log.py src tests/test_gemini_normalize.pynormalize_gemini_request()passed.The full pytest suite could not be run in this environment because
pytestis not installed in the available Python environments.