fix(supabase): confirm the recovery session before calling setSession - #438
Open
Cypher-Aura-19 wants to merge 1 commit into
Open
Cypher-Aura-19 wants to merge 1 commit into
Cypher-Aura-19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a short Password recovery subsection to the Supabase skill's
## Debuggingsection so agents establish which stage of a recovery/auth-callback flow already succeeded before changing session state.Why
A recovery flow may already have established the recovery session before the application renders.
Without guidance for that case, an agent can incorrectly add manual
supabase.auth.setSession()handling even though session establishment has already happened, disrupting an otherwise successful recovery flow.Change
The guidance now tells agents to:
PASSWORD_RECOVERYwhen appropriate instead of automatically establishing another session;token_hash+verifyOtp, and PKCE/code-exchange flows;setSession()is not treated as universally wrong. The guidance only avoids calling it redundantly when the recovery session has already been established.Verification
vitest run— 7/7 tests passgit diff --check— cleanskills/supabase/SKILL.mdFixes #430.