fix(gotrue): sign out locally even if the server call fails - #448
Merged
Merged
Conversation
Tr00d
reviewed
Sep 28, 2026
Tr00d
left a comment
Tr00d
left a comment
Contributor
There was a problem hiding this comment.
LGTM, there's only one assertion to add on a test
Contributor
Author
|
@Tr00d good catch, the others scope test now checks the persisted session too |
Tr00d
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #280
sign-out now clears the local session even if the server call fails, and the others scope keeps it, same as signOut in auth-js. unlike auth-js, 401/403/404 still throw, to keep the error contract.