Skip to content

fix(functions): send the caller's content-type instead of dropping it #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tr00d merged 1 commit into from
Sep 28, 2026
+22 −5
Merged

fix(functions): send the caller's content-type instead of dropping it #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/Functions/Functions.Tests/ClientContractTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,17 @@ public async Task Invoke_ShouldPreferOptionHeadersOverDynamicHeaders()
this.HeaderOf("x-shared").Should().Be("from-options");
}

[TestMethod]
public async Task Invoke_ShouldSendOptionContentType_GivenLowercaseHeaderName()
{
this.RespondWith(200, "ok");
await this.client.Invoke(FunctionName, options: new InvokeFunctionOptions
{
Headers = new Dictionary<string, string> { { "content-type", "text/plain" } }
});
this.HeaderOf("Content-Type").Should().Be("text/plain");
}

[TestMethod]
public async Task Invoke_ShouldThrowFunctionsException_GivenServerError()
{
Expand Down
16 changes: 11 additions & 5 deletions packages/Functions/Functions/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,20 @@ private static Uri BuildUri(string url)

private static HttpRequestMessage BuildRequestMessage(InvokeFunctionOptions options, Uri uri)
{
var request = new HttpRequestMessage(options.HttpMethod, uri)
{
Content = new StringContent(JsonSerializer.Serialize(options.Body, SerializerOptions), Encoding.UTF8, "application/json")
};
var content = new StringContent(JsonSerializer.Serialize(options.Body, SerializerOptions), Encoding.UTF8, "application/json");
var request = new HttpRequestMessage(options.HttpMethod, uri) { Content = content };

foreach (var kvp in options.Headers)
{
request.Headers.TryAddWithoutValidation(kvp.Key, kvp.Value);
if (string.Equals(kvp.Key, "Content-Type", StringComparison.OrdinalIgnoreCase))
{
content.Headers.Remove("Content-Type");
content.Headers.TryAddWithoutValidation("Content-Type", kvp.Value);
}
else
{
request.Headers.TryAddWithoutValidation(kvp.Key, kvp.Value);
}
}

return request;
Expand Down
Loading