feat: looseAttributePrefixes option to exempt prefixed attributes from type checking - #3089
Open
khromov wants to merge 3 commits into
Open
feat: looseAttributePrefixes option to exempt prefixed attributes from type checking#3089khromov wants to merge 3 commits into
khromov wants to merge 3 commits into
Conversation
…m type checking Attributes whose names start with a prefix configured via svelteOptions.looseAttributePrefixes in tsconfig/jsconfig are treated like data-* attributes (spread into __sveltets_2_empty), on both elements and components. Useful for preprocessors that consume namespaced template directives before the Svelte compiler runs. Plumbed through the language server (TS and tsgo paths), the typescript-plugin, and svelte-check's incremental mode (with cache invalidation when the option changes).
…and docs note - Move sanitizeLooseAttributePrefixes into svelte2tsx internalHelpers and apply it inside convertHtmlxToJsx so all entry points are guarded - Reuse the shared helper in language-server, svelte-check and typescript-plugin (closes the unsanitized path in the plugin) - Add changeset for the new feature - Document that svelteOptions is not picked up through tsconfig extends
🦋 Changeset detectedLatest commit: cb87ee3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attributes whose names start with a prefix configured via svelteOptions.looseAttributePrefixes in tsconfig/jsconfig are treated like data-* attributes (spread into __sveltets_2_empty), on both elements and components. Useful for preprocessors that consume namespaced template directives before the Svelte compiler runs.
Plumbed through the language server (TS and tsgo paths), the typescript-plugin, and svelte-check's incremental mode (with cache invalidation when the option changes).
This is a small patch so we can avoid doing this ugly svelte-check patch in Mochi.