Repository navigation
Show HFS+ volume names and GPT partition names; stop listing GPT tables as unpartitioned space - #174
Merged
Merged
Conversation
…he GPT tables as unpartitioned space Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017DPjyZZHvaivtvJ3N4hZhz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by comparing the volume tree for a GPT disk image against FTK Imager's. Three differences, each fixed here.
What changes for examiners
Verification
tests/imagebuild_gpt.pyandtests/test_volume_gpt.py(8 tests: names, HFS+ label, label without indexing the catalog, damaged catalog gives no label rather than an error, gap boundaries, trailing gap, no gaps on a full disk). Five fail and one errors on the old code.🤖 Generated with Claude Code
https://claude.ai/code/session_017DPjyZZHvaivtvJ3N4hZhz
Generated by Claude Code