Repository navigation
Make Enter submit a dialog instead of cancelling it - #177
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017DPjyZZHvaivtvJ3N4hZhz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for examiners
Pressing Enter in a dialog's text field cancelled the dialog instead of submitting it: the BitLocker/LUKS unlock dialog, the examiner-name dialogs, New case, Open case, tagging, and every other dialog with a Cancel button.
Cause: each dialog is a
<form method="dialog">, and Enter presses the form's first submit button. Cancel comes first in each menu, so Enter was Cancel. The Cancel buttons are now plain buttons (type="button") that close their dialog themselves, which leaves the confirm button as the form's default. Clicking Cancel still cancels, Escape still works.Verification
returnValue = "ok". Before the change the same steps gave"cancel"for all four. Clicking Cancel still gives"cancel".tests/test_dialogs.pychecks the markup (no Cancel is a submit button; no dialog's first submit button is a Cancel) and that the script closes the dialog on Cancel; two of its three tests fail on the old markup.web/index.html,web/app.js).🤖 Generated with Claude Code
https://claude.ai/code/session_017DPjyZZHvaivtvJ3N4hZhz
Generated by Claude Code