Euler & Pareto - #135
Merged
Merged
Conversation
Bailsec, Aug 2026. Audited symbioticfi/core-mirror at 80c346e, with resolutions reviewed at 87348bb and a8846cd. 14 findings, no High: 2 Medium (1 resolved, 1 partially resolved), 8 Low and 4 Informational (all acknowledged). Scope covers ParetoOracle, ParetoAccount and the Euler adapter. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1kresh
added a commit
that referenced
this pull request
Aug 7, 2026
TruffleHog's Lob detector matches `test_` followed by 35 alphanumerics, which is exactly the shape of many Foundry test names recorded in snapshots/gas.txt (e.g. test_AddAdapterUsesAdapterWhitelistEntry). That produced 56 findings on PR #135, all in snapshots/gas.txt and all test names. Because the bullfrog egress filter blocks api.lob.com, they could not be verified and so surfaced under `--results=verified,unknown`, failing the scan with exit 183. Reproduced with trufflehog 3.96.0 over the same commit range: 56 Lob findings, 25 unique, every one a test function name. With `--exclude-detectors=lob`: 0 findings. A postal-mail API key cannot legitimately appear in this repository, so no coverage is lost. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1kresh
added a commit
that referenced
this pull request
Aug 7, 2026
The first `test` run on main after every merge starts with a cold Foundry RPC cache: Actions scopes caches per ref, and main cannot read the entries a PR branch wrote. Cold, the mainnet suites fetch all fork state at once and the provider answers HTTP 429, so vm.createSelectFork and vm.deployCode fail across the suite. That failed run 31197476561 (merge of #136) and run 31138998090 (merge of #135); the same commits passed on their PRs, where the cache restored warm (~2 MB). Retry the forge step up to 3 times with 60s/120s backoff. Foundry persists every response it does receive to ~/.foundry/cache/rpc, so each attempt starts warmer and needs fewer live requests - retrying in-job converges where a fresh run cannot. Only 429s are retried; any other failure exits on the first attempt, so a real regression still reports immediately instead of after three passes. Verified by rendering the step out of the workflow with the matrix expression substituted as Actions would, then running it under `bash -e` against a stubbed forge: 429-then-pass exits 0 after 3 invocations, a plain revert exits 1 after 1 invocation with no retry, and persistent 429s exit 1 after 3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.