Skip to content

feat: add tui cancel + windows tests #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laynepenney merged 1 commit into from
Feb 7, 2026
Merged

feat: add tui cancel + windows tests #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions codi-rs/src/tui/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,10 @@ impl App {
self.agent = Some(agent);
self.pending_agent = None;
self.pending_agent_cancel = None;
self.cancel_requested = false;
match result {
Ok(_) => {
// Response was streamed via callbacks; TurnComplete will finalize
self.cancel_requested = false;
}
Err(e) => {
let cancelled = e
Expand All @@ -454,7 +454,9 @@ impl App {
self.mode = AppMode::Normal;
self.turn_start_time = None;
self.finalize_streaming();
// Leave cancel_requested set until the next request starts.
} else {
self.cancel_requested = false;
self.status = Some(format!("Error: {}", e));
self.mode = AppMode::Normal;
self.finalize_streaming();
Expand All @@ -472,11 +474,11 @@ impl App {
self.turn_start_time = None;
self.finalize_streaming();
} else {
self.cancel_requested = false;
self.status = Some("Agent task failed unexpectedly".to_string());
self.mode = AppMode::Normal;
self.finalize_streaming();
}
self.cancel_requested = false;
}
Err(tokio::sync::oneshot::error::TryRecvError::Empty) => {
// Still running, keep waiting
Expand Down