Repository navigation
Add a bunch of tests to everything, start to work to pass them. - #1
Merged
Merged
Conversation
Summary from Claude: Bounds: a reference to a constant that's zero, negative or non-integer now fails for the positive, non-negative and integer types. Arrays: a reference must resolve to a list. With ListOfStringsOrRef or ListOfNumbersOrRef, the elements must also be strings or numbers. Elements that are themselves references are accepted. Dicts: a reference must resolve to an object, and its values are checked when the field says they must be strings. Model targets: #tasks:model1.model now fails in all the scalar, array and dict fields. It was silent before. Loose cases: these are recorded in CreateTests.md. A dict field fed a data output is not flagged. A string-array field fed an annotatedData output is not flagged, because labels can be strings. A number-array field fed a stringList output is. NumericRange.values: NumericRange re-declares Range's values, so a bad reference there correctly fires both NumericRange-0012 and Range-0002. Two fixtures are renamed to say so, for example NumericRange-0012-fail-01-scalar_constant-Range-0002-01. I used underscores in the test name because the harness's file-name pattern can't tell a hyphenated name from the start of a chain. The generator does this automatically. Wider effects: rules_data.py was stale and lacked SEDBase-0016/-0017, so regenerating it added them. The schema-tier fixtures aren't in the folder, so I regenerated 50 of them in scratch and all pass. The generator dropped 15 others for firing extra rules, which I didn't check against the old code. Java and C++: they still have no validation dispatch at all, so these checks are owed there before the next merge (per Claude.md). I noted that in the TODO list in CreateTests.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.