Repository navigation
Use SWIG differently, so we have a single Python binary instead of one per Python version. - #1401
Merged
Merged
Conversation
…sion. We have to start by moving our creation of NamedArray to python instead of C++.
This is the big moment, when we can see if we indeed don't need four binaries all the time. Lots of tests added and CI restructured so that we build on Python 3.10, then test there and on the most recent versions of python. Also test numpy version 1.21.3, 2.2.x, and 3.x, which should, in theory, all work.
Merge from develop
Also just require SWIG 4.4.1 or later everywhere.
Works fine on mac/windows, but linux was crashing sometimes. Probably due to multiple loads of the library?
Can happen when both roadrunner and rrplugins are present.
Author
|
This all works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to change how we create NamedArrays and also (I think) change how we use SWIG.