Skip to content

Share EVM fee discovery between extension and mobile - #240

Closed
sidhujag wants to merge 304 commits into
syscoin:mainfrom
sidhujag:codex/shared-evm-fee-core
Closed

sidhujag wants to merge 304 commits into
syscoin:mainfrom
sidhujag:codex/shared-evm-fee-core

Conversation

@sidhujag

@sidhujag sidhujag commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

The extension already obtains EVM fees through sysweb3, while mobile had a separate implementation. This exposes that existing calculation through a dependency-free cjs/evm-fees API and makes EthereumTransactions delegate to it, so both hosts share legacy/EIP-1559 recommendations and explicit unsupported-method history fallback.

The restricted API accepts a read-only provider and optional synchronous ownership/abort guards; it imports no signer, wallet or provider implementation. It retains zero-tip behavior and adds bounded quantities/history. The package candidate is 2.2.0 and has not been published.

Validation: 201 affected fee/provider/helper tests pass and exit successfully, TypeScript and both builds pass, and isolated packaged API type/runtime checks pass with zero transitive imports. The full 59-suite run reported 1,816 passing tests but retained open handles afterward and was stopped; hosted CI must qualify a clean completion. All unrelated package files match the official 2.1.0 package. Further independent review and Pali integration qualification remain required.

Closed: this targets the older upstream repository. The active published SDK baseline is sidhujag/sysweb3 main; the focused six-file PR is opened there.

lucasgabrielgsp and others added 30 commits August 13, 2025 15:18
…hmac for ledger

to prevent silent failures we enable display=true to get xpub as a fallback (for unusual paths).

wallet hmac allows us to process non standard policies silently without requiring display
solve some typescript lints as well
refactor: isolate vault persistence behind async host storage
refactor: separate transaction hardware adapters from software core
feat: add an isolated software keyring entry
fix: preserve Pali EVM fee approvals in the shared keyring
build: omit compiled tests from keyring releases
Migrate Trezor transport to Connect 10 with fenced cancellation
Remove legacy Trezor UTXO helpers with verified serialization parity
Move Ledger signing to a verified semantic DMK host
Add offline prepared EVM signing for software hosts
…eparation (#48)

* feat(keyring): prepare bounded BIP84 native transfers

* fix(keyring): bound aggregate parent decoder components
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-04T15:03:39.527262Z
We couldn’t complete this review. Comment @codex review to try again.
3220056 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sidhujag sidhujag closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants