Repository navigation
Conversation
…hmac for ledger to prevent silent failures we enable display=true to get xpub as a fallback (for unusual paths). wallet hmac allows us to process non standard policies silently without requiring display
initEccLib inside keyring
solve some typescript lints as well
refactor: isolate vault persistence behind async host storage
refactor: separate transaction hardware adapters from software core
feat: add an isolated software keyring entry
fix: preserve Pali EVM fee approvals in the shared keyring
chore: prepare keyring 1.0.628
build: omit compiled tests from keyring releases
Migrate Trezor transport to Connect 10 with fenced cancellation
Remove legacy Trezor UTXO helpers with verified serialization parity
Move Ledger signing to a verified semantic DMK host
Add offline prepared EVM signing for software hosts
…eparation (#48) * feat(keyring): prepare bounded BIP84 native transfers * fix(keyring): bound aggregate parent decoder components
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension already obtains EVM fees through sysweb3, while mobile had a separate implementation. This exposes that existing calculation through a dependency-free
cjs/evm-feesAPI and makesEthereumTransactionsdelegate to it, so both hosts share legacy/EIP-1559 recommendations and explicit unsupported-method history fallback.The restricted API accepts a read-only provider and optional synchronous ownership/abort guards; it imports no signer, wallet or provider implementation. It retains zero-tip behavior and adds bounded quantities/history. The package candidate is 2.2.0 and has not been published.
Validation: 201 affected fee/provider/helper tests pass and exit successfully, TypeScript and both builds pass, and isolated packaged API type/runtime checks pass with zero transitive imports. The full 59-suite run reported 1,816 passing tests but retained open handles afterward and was stopped; hosted CI must qualify a clean completion. All unrelated package files match the official 2.1.0 package. Further independent review and Pali integration qualification remain required.
Closed: this targets the older upstream repository. The active published SDK baseline is sidhujag/sysweb3 main; the focused six-file PR is opened there.