Draft: Emulate hard-linking symlinks on macOS hosts#239
Closed
doanbaotrung wants to merge 0 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS hosts, native linkat(2) returns EINVAL when linking a symbolic link directly (i.e. with AT_SYMLINK_NOFOLLOW). Linux allows this unconditionally.
Emulate this by reading the symlink target, converting any absolute target path to a relative path to keep it contained in the sysroot, and creating a new symbolic link at the destination using symlinkat.
Fix #237
Summary by cubic
Emulates Linux behavior on macOS for hard-linking a symlink:
linkat(..., AT_SYMLINK_NOFOLLOW)now creates a new symlink at the destination with the same target. Absolute targets are rewritten to relative to keep links within the sysroot. Fixes #237.New Features
AT_SYMLINK_NOFOLLOWis set (handlesEINVAL).linkatemulation andsymlinkat.Refactors
dirfd_guest_base_pathfor target normalization.symlinkatin the syscall dispatcher.Written for commit 12df8f2. Summary will update on new commits.