Emulate linkat on macOS symlinks and escape logs#240
Open
doanbaotrung wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
doanbaotrung
changed the title
jserv
reviewed
Jul 23, 2026
On macOS, linkat(2) fails with EINVAL when attempting to hard-link a symbolic link itself. Fall back to creating a new symlink to the same target when host linkat returns EINVAL. In addition, sanitize verbose tracing logs by escaping control characters in guest-provided path strings. This prevents guests from injecting terminal escape sequences into the operator's terminal. Fix sysprog21#237
doanbaotrung
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, linkat(2) fails with EINVAL when attempting to hard-link a
symbolic link itself. Fall back to creating a new symlink to the same
target when host linkat returns EINVAL.
In addition, sanitize verbose tracing logs by escaping control
characters in guest-provided path strings. This prevents guests
from injecting terminal escape sequences into the operator's
terminal.
Fix #237
Summary by cubic
Stop falling back to host paths for system directories when a guest path is missing in the sysroot. Prevents guest writes to the host and avoids SIP-related EPERM/EACCES on macOS.
EINVALinlinkatas non-fallback to avoid host writes.openat/readlinkat/faccessat, and target+linkpath forsymlinkat.Written for commit c40996c. Summary will update on new commits.