Repository navigation
Disable wasm-opt in wasm-pack profiles to unblock test (ubuntu-latest, 20) - #1
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job test (ubuntu-latest, 20)
Disable wasm-opt in wasm-pack profiles to unblock Jun 5, 2026
test (ubuntu-latest, 20)
tahzeer
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test-wasmGitHub Actions matrix job forubuntu-latest+ Node 20 was failing duringwasm-pack build --target nodejsbecausewasm-optfailed in CI (Binaryen validation/compatibility path). This change removes that failure mode from the wasm package build configuration used by the job.CI failure point
crates/wasmbuild invokedwasm-optthrough wasm-pack profile metadata and failed before JS integration tests could run.Configuration change
crates/wasm/Cargo.tomlto disablewasm-optfor both dev and release profiles.Resulting behavior
wasm-pack buildno longer depends onwasm-optin this crate’s CI path, allowing the Node-target wasm build to proceed in the affected runner/job configuration.