Skip to content

Disable wasm-opt in wasm-pack profiles to unblock test (ubuntu-latest, 20) - #1

Merged
tahzeer merged 2 commits into
masterfrom
copilot/fix-test-ubuntu-latest-20
Jun 5, 2026
Merged

tahzeer merged 2 commits into
masterfrom
copilot/fix-test-ubuntu-latest-20

Conversation

Copilot AI commented Jun 5, 2026 •

Copy link
Copy Markdown
Contributor

The test-wasm GitHub Actions matrix job for ubuntu-latest + Node 20 was failing during wasm-pack build --target nodejs because wasm-opt failed in CI (Binaryen validation/compatibility path). This change removes that failure mode from the wasm package build configuration used by the job.

  • CI failure point

    • crates/wasm build invoked wasm-opt through wasm-pack profile metadata and failed before JS integration tests could run.
  • Configuration change

    • Updated wasm-pack profile settings in crates/wasm/Cargo.toml to disable wasm-opt for both dev and release profiles.
    • Scope is limited to wasm-pack metadata; no parser/runtime logic changes.
  • Resulting behavior

    • wasm-pack build no longer depends on wasm-opt in this crate’s CI path, allowing the Node-target wasm build to proceed in the affected runner/job configuration.
[package.metadata.wasm-pack.profile.release]
wasm-opt = false

[package.metadata.wasm-pack.profile.dev]
wasm-opt = false

Copilot AI changed the title [WIP] Fix failing GitHub Actions job test (ubuntu-latest, 20) Disable wasm-opt in wasm-pack profiles to unblock test (ubuntu-latest, 20) Jun 5, 2026
Copilot AI requested a review from tahzeer June 5, 2026 10:35
Copilot AI requested a review from tahzeer June 5, 2026 10:55
@tahzeer
tahzeer marked this pull request as ready for review June 5, 2026 10:55
@tahzeer
tahzeer merged commit 10a6ed3 into master Jun 5, 2026
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants