Repository navigation
Conversation
The data pointer escaped withUnsafeBytes before write used it, which could send incorrect bytes for short messages in optimized builds. Perform the write inside the closure to keep the pointer valid. Fixes tailscale/tailscale#22025 Signed-off-by: Mattt Zmuda <mattt@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutgoingConnection.sendpasses a pointer out ofwithUnsafeBytesand then writes from it. In optimized builds, short messages can arrive as the wrong bytes.This PR does the write inside the closure, so the pointer stays valid while
writeuses it, and adds a test that sends a four-byte message through the existing connection test and checks the exact bytes received.#55 also rewrites this line and the connection tests, and keeps the escaped pointer, so the closure form should survive whichever lands first.
Fixes tailscale/tailscale#22025