Repository navigation
system: expect the vfio-pci vIOMMU error with amd-iommu in the x86 test - #334
Merged
Merged
Conversation
tamnd
added
kind/bug
tamnd
modified the milestones:
M6: macOS, Windows, Arm, RISC-V,
M8: Passthrough, vIOMMU, confidential
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a test broken by #330:
x86::tests::vfio_pci_propertiesin ruvm-system fails on Linux since then. #330 lets vfio-pci sit behind intel-iommu, so a plan with intel-iommu and vfio-pci no longer fails, but the test still expected the "vfio-pci with a vIOMMU is not supported by ruvm yet" error for that pair. The test only builds on Linux, so the macOS checks did not catch it.The check now uses amd-iommu, which still sends the container no notifications and still gets the error. Nothing outside the test changes.
Checked on server2:
cargo test -p ruvm-system --libpasses again with the change, and the test fails on the current main without it. There is no QEMU side to compare, since this is a ruvm test of ruvm's own refusal.Part of #7.