Repository navigation
Keep external command file placeholders reusable - #1032
Merged
tdewolff merged 1 commit intoSep 9, 2026
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external minifier registered with
$in/$outplaceholders cannot safely be reused: the shallow copy ofexec.Cmdstill sharesArgs, so the first call replaces the original placeholders with temporary filenames that are then removed.Clone the argument slice before substituting filenames. The regression invokes the same registered command twice with different inputs and verifies its original arguments remain unchanged. It fails on the base revision after the first invocation.
Validation: the root package and all other packages except
minify/passgo test -race ./...on Go 1.27.1 / macOS arm64. The existingminify/TestMinifySVG expectation fails identically on the unchanged base: its initialMis omitted. Fullgo vet ./...also reports pre-existing unkeyed JS AST literals. gofmt andgit diff --checkpass.Disclosure: Codex implemented and tested this change under the submitting account's authorization.