Repository navigation
Return output write errors from external minifiers - #1033
Merged
tdewolff merged 2 commits intoSep 9, 2026
Merged
Conversation
Owner
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an external minifier writes through a
$outfile, the deferred copy to the caller's writer discards its error. A failed write or short write consequently looks like successful minification.Copy the command's output before returning and propagate copy errors when the command itself succeeded. Preserve the command error if the subprocess failed. Regressions verify both a writer returning an error and a short write; both returned
nilon the base revision.Validation:
go test -race .,go vet ., gofmt andgit diff --checkpass on Go 1.27.1 / macOS arm64. The broader suite has an independently verified base failure inminify/TestMinify(missing initial SVGM); broad vet also reports existing unkeyed JS AST literals.Disclosure: Codex implemented and tested this change under the submitting account's authorization.