Skip to content

Build: fixes #447: JaCoCo instrumentation exceptions on newer JDKs #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svanteschubert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build: fixes #447: JaCoCo instrumentation exceptions on newer JDKs #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion odfdom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<useModulePath>false</useModulePath>
<argLine>-javaagent:${settings.localRepository}/org/jacoco/org.jacoco.agent/${jacoco.version}/org.jacoco.agent-${jacoco.version}-runtime.jar=destfile=${project.build.directory}/coverage-reports/jacoco-ut.exec</argLine>
<argLine>-javaagent:${settings.localRepository}/org/jacoco/org.jacoco.agent/${jacoco.version}/org.jacoco.agent-${jacoco.version}-runtime.jar=destfile=${project.build.directory}/coverage-reports/jacoco-ut.exec,excludes=${jacoco.agent.excludes}</argLine>
<systemPropertyVariables>
<org.odftoolkit.odfdom.validation>true</org.odftoolkit.odfdom.validation>
</systemPropertyVariables>
Expand Down
11 changes: 10 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@
<maven.javadoc.failOnError>false</maven.javadoc.failOnError>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm:ss</maven.build.timestamp.format>
<!-- JaCoCo Properties -->
<jacoco.version>0.8.14</jacoco.version>
<jacoco.version>0.8.15</jacoco.version>
<!-- JDK classes are never instrumented by the JaCoCo agent, as newer JDKs might use class file
versions unknown to JaCoCo resulting into exceptions in the build log -->
<jacoco.agent.excludes>java.*:javax.*:jdk.*:sun.*:com.sun.*</jacoco.agent.excludes>
<sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
<sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
<sonar.coverage.jacoco.xmlReportPaths>${project.reporting.outputDirectory}/jacoco-ut/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
Expand Down Expand Up @@ -494,6 +497,9 @@
<configuration>
<!-- Sets the path to the file which contains the execution data. -->
<destFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</destFile>
<excludes>
<exclude>${jacoco.agent.excludes}</exclude>
</excludes>
<!--
Sets the name of the property containing the settings
for JaCoCo runtime agent.
Expand Down Expand Up @@ -535,6 +541,9 @@
<configuration>
<!-- Sets the path to the file which contains the execution data. -->
<destFile>${project.build.directory}/coverage-reports/jacoco-it.exec</destFile>
<excludes>
<exclude>${jacoco.agent.excludes}</exclude>
</excludes>
<!--
Sets the name of the property containing the settings
for JaCoCo runtime agent.
Expand Down
Loading