Repository navigation
feat(decision): keep a trace when any check flags it, with per-question thresholds and severity - #1
Merged
Conversation
…on thresholds and severity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the logarithmic pool with an any-of rule. Averaging the checks let the ones that said "no" pull down a trace that had one real failure, which lowered recall.
Changes
answer_wrong, or any question in the manifest'sdecision.any_of, reaches its threshold.decision.thresholdssets a question's own threshold; questions without one usepolicy.keep_threshold.answer_wrongranks first, thenany_ofin the order written. Ranks become rank-order centroid weights that sum to 1.eval.answers.<question>,eval.flags,eval.severity), and they travel through the export queue.pipeline.Pooland thedecision.intercept/decision.weightsmanifest keys.Notes for reviewers
decision.thresholdsor a shorterany_of.decisionblock decides exactly as before.Testing
make lintandmake testpass. New tests cover the weights, per-check decisions and severity, manifest validation, the log fields, the export attributes and the queue round trip.