Revert "REF: Remove unnecessary viz module" - #120
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 62.15% 62.15%
=======================================
Files 13 13
Lines 2658 2658
=======================================
Hits 1652 1652
Misses 1006 1006
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
keep my position of +1 to remove, the module and the associated CLI. Not sure why the CI's did not catch it in first place. |
|
I still believe that it should not be distributed with the package, but happy to chat in case my viewpoint does not faithfully represent what the purpose of the package is. I believe that the visualization CLI should dwell in DIPY. MY bad for not having checked uses of the function across the code. PR #124 to remove the leftovers I we believe the decisions was right. |
|
Could probably close this, based on outcome of the conversation on #119 |
Reverts #118
@jhlegarreta and @skoudoro : should we reconsider in light of the use of these visualizations in this CLI function? https://github.com/tee-ar-ex/trx-python/blob/master/trx/workflows.py#L276