Repository navigation
Conversation
Bumps apiVersion from tekton.dev/v1beta1 to tekton.dev/v1 for: helm-conftest (0.1 → 0.2), pytest (0.2 → 0.3), robot-framework (0.1 → 0.2), asciidoctor (0.1 → 0.2), upload-pypi (0.2 → 0.3), cloudevent (0.1 → 0.2), prometheus-gate (0.1 → 0.2). Each new version was created using copy-then-modify per CONTRIBUTING.md. upload-pypi: pinned twine image with sha256 digest. prometheus-gate: PipelineRun sample serviceAccountName moved to spec.taskRunTemplate.serviceAccountName per Tekton v1 API. Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/assign @vdemeester |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
API version bump for 7 testing, publishing, and miscellaneous tasks, continuing the v1beta1 → v1 migration tracked in #1381.
Tasks updated
Each new version was created using
copy-then-modifyper CONTRIBUTING.md.Image pinning
Most images here were already safe — either pinned by digest or passed through task params. The one exception was
upload-pypi, which hardcodes a mutable tag in its second step:upload:quay.io/thoth-station/twine:v0.0.2— pinned with@sha256:1d7eabedfb2fb72b816e5a06e995966fa74c42a0df38ac0065a02caa48b7dc97build: image provided via$(params.BUILDER_IMAGE)Fixes applied during review
Three things came up during local validation that were worth fixing:
cloudeventhas aconfig/task.yamlalongside the maincloudevent.yaml. The initial pass only updated the main YAML, leavingconfig/task.yamlstill on v1beta1. Fixed — apiVersion, version label, and minVersion all bumped in the config copy too.prometheus-gatePipelineRun sample hadspec.serviceAccountName, which is invalid in the v1 API. Moved it tospec.taskRunTemplate.serviceAccountName(same pattern applied in chore(deployment): bump apiVersion from v1beta1 to v1 #1392 and chore(cloud): bump apiVersion v1beta1 → v1 for 11 cloud/storage tasks #1398).upload-pypitwine image was using a mutable tag (v0.0.2) with no digest. Pinned it viaskopeo inspectto lock the exact image content.Additional changes
Validation
v1beta1references across all 7 new version directories (32 files)Ref: #1381
/kind cleanup
Submitter Checklist