Skip to content

chore(misc): bump apiVersion v1beta1 → v1 for 7 testing/publishing tasks - #1400

Open
gferreir wants to merge 1 commit into
tektoncd:mainfrom
gferreir:chore/misc-api-v1-bump
Open

gferreir wants to merge 1 commit into
tektoncd:mainfrom
gferreir:chore/misc-api-v1-bump

Conversation

@gferreir

Copy link
Copy Markdown
Contributor

Changes

API version bump for 7 testing, publishing, and miscellaneous tasks, continuing the v1beta1 → v1 migration tracked in #1381.

Tasks updated

Task Old → New Changes
helm-conftest 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
pytest 0.2 → 0.3 apiVersion v1, minVersion 0.50.0
robot-framework 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
asciidoctor 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
upload-pypi 0.2 → 0.3 apiVersion v1, minVersion 0.50.0, image pinned
cloudevent 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
prometheus-gate 0.1 → 0.2 apiVersion v1, minVersion 0.50.0

Each new version was created using copy-then-modify per CONTRIBUTING.md.

Image pinning

Most images here were already safe — either pinned by digest or passed through task params. The one exception was upload-pypi, which hardcodes a mutable tag in its second step:

  • upload-pypi step upload: quay.io/thoth-station/twine:v0.0.2 — pinned with @sha256:1d7eabedfb2fb72b816e5a06e995966fa74c42a0df38ac0065a02caa48b7dc97
  • helm-conftest, cloudevent, prometheus-gate: images already pinned by sha256 digest
  • pytest, robot-framework, asciidoctor: image provided via task params
  • upload-pypi step build: image provided via $(params.BUILDER_IMAGE)

Fixes applied during review

Three things came up during local validation that were worth fixing:

  1. cloudevent has a config/task.yaml alongside the main cloudevent.yaml. The initial pass only updated the main YAML, leaving config/task.yaml still on v1beta1. Fixed — apiVersion, version label, and minVersion all bumped in the config copy too.

  2. prometheus-gate PipelineRun sample had spec.serviceAccountName, which is invalid in the v1 API. Moved it to spec.taskRunTemplate.serviceAccountName (same pattern applied in chore(deployment): bump apiVersion from v1beta1 to v1 #1392 and chore(cloud): bump apiVersion v1beta1 → v1 for 11 cloud/storage tasks #1398).

  3. upload-pypi twine image was using a mutable tag (v0.0.2) with no digest. Pinned it via skopeo inspect to lock the exact image content.

Additional changes

  • Tests: pytest, robot-framework, asciidoctor, and upload-pypi test manifests bumped to v1
  • Samples: upload-pypi and cloudevent samples bumped to v1
  • prometheus-gate samples: PipelineRun and Pipeline manifests bumped to v1
  • Hook permissions: robot-framework pre-apply hook kept at 755 (matching original)

Validation

  • Zero remaining v1beta1 references across all 7 new version directories (32 files)
  • File count matches between old and new versions for every task
  • Semantic diff confirms only expected fields changed in task YAMLs (plus the twine image pin)
  • Original versions untouched
  • Single commit, DCO signed

Ref: #1381

/kind cleanup

Submitter Checklist

Bumps apiVersion from tekton.dev/v1beta1 to tekton.dev/v1 for:
helm-conftest (0.1 → 0.2), pytest (0.2 → 0.3),
robot-framework (0.1 → 0.2), asciidoctor (0.1 → 0.2),
upload-pypi (0.2 → 0.3), cloudevent (0.1 → 0.2),
prometheus-gate (0.1 → 0.2).

Each new version was created using copy-then-modify per CONTRIBUTING.md.
upload-pypi: pinned twine image with sha256 digest.
prometheus-gate: PipelineRun sample serviceAccountName moved to
spec.taskRunTemplate.serviceAccountName per Tekton v1 API.

Ref: tektoncd#1381

Signed-off-by: gferreir <guilherme.nmf@gmail.com>
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 23, 2026
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2026
@gferreir

Copy link
Copy Markdown
Contributor Author

/assign @vdemeester

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants