Repository navigation
chore(git-gitlab): bump apiVersion v1beta1 → v1 for 8 git/gitlab tasks - #1404
Merged
Merged
Conversation
Bumps apiVersion from tekton.dev/v1beta1 to tekton.dev/v1 for: git-cli (0.4 → 0.5), git-rebase (0.1 → 0.2), git-version (0.1 → 0.2), gitea-set-status (0.1 → 0.2), gitlab-add-label (0.1 → 0.2), gitlab-set-status (0.2 → 0.4), create-gitlab-release (0.1 → 0.2), scorecard (0.1 → 0.2). Each new version was created using copy-then-modify per CONTRIBUTING.md. gitlab-add-label: pinned ubi8/ubi:8.2 image with sha256 digest. create-gitlab-release: pinned ubi8/ubi-minimal:8.2 image with sha256 digest. git-rebase: PipelineRun sample serviceAccountName moved to spec.taskRunTemplate.serviceAccountName per Tekton v1 API. gitlab-set-status: bumped to 0.4 (skipping 0.3) to avoid version collision with open PR tektoncd#1324 which also creates 0.3. Ref: tektoncd#1381 Signed-off-by: gferreir <guilherme.nmf@gmail.com>
Contributor
Author
|
/assign @vdemeester |
5 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
API version bump for 8 git and gitlab tasks, continuing the v1beta1 → v1 migration tracked in #1381.
Tasks updated
Each new version was created using
copy-then-modifyper CONTRIBUTING.md.Image pinning
Two tasks had hardcoded mutable UBI8 images. Both pinned with digests already resolved via
skopeo inspect:registry.access.redhat.com/ubi8/ubi:8.2→ pinned with@sha256:d748c21a55796827da82c61f162b505c59451cba24f1874e5185f21275b6bddcregistry.access.redhat.com/ubi8/ubi-minimal:8.2→ pinned with@sha256:5cfbaf45ca96806917830c183e9f37df2e913b187aadb32e89fd83fa455ebaa6Why gitlab-set-status jumps to 0.4
PR #1324 (open since 2024,
needs-ok-to-test) also creates agitlab-set-status/0.3. That PR adds SSL verification options — a different change from the API bump done here. To avoid a version collision, this PR creates 0.4 directly, skipping 0.3. If #1324 merges at some point, 0.3 would carry its SSL fix on v1beta1, while 0.4 carries the v1 bump. No conflict either way.Additional changes
spec.serviceAccountNamemoved tospec.taskRunTemplate.serviceAccountNameper Tekton v1 APItests/fixtures/directories with mock HTTP responses — preserved as-is (no Tekton apiVersions inside)Validation
v1beta1references across all 8 new version directories (31 files)Note on pre-existing conditions
git-cli,git-rebase,gitea-set-status,gitlab-add-label,gitlab-set-status,create-gitlab-release, andscorecardinterpolate$(params.*)directly inscript:blocks.These patterns are inherited from previous versions and not introduced by this PR.
Script injection hardening will be addressed in a separate batch as part of #1381.
Ref: #1381
/kind cleanup
Submitter Checklist