Skip to content

chore(git-gitlab): bump apiVersion v1beta1 → v1 for 8 git/gitlab tasks - #1404

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
gferreir:chore/git-gitlab-api-v1-bump
Oct 1, 2026
Merged

tekton-robot merged 1 commit into
tektoncd:mainfrom
gferreir:chore/git-gitlab-api-v1-bump

Conversation

@gferreir

Copy link
Copy Markdown
Contributor

Changes

API version bump for 8 git and gitlab tasks, continuing the v1beta1 → v1 migration tracked in #1381.

Tasks updated

Task Old → New Changes
git-cli 0.4 → 0.5 apiVersion v1, minVersion 0.50.0
git-rebase 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
git-version 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
gitea-set-status 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
gitlab-add-label 0.1 → 0.2 apiVersion v1, minVersion 0.50.0, image pinned
gitlab-set-status 0.2 → 0.4 apiVersion v1, minVersion 0.50.0
create-gitlab-release 0.1 → 0.2 apiVersion v1, minVersion 0.50.0, image pinned
scorecard 0.1 → 0.2 apiVersion v1, minVersion 0.50.0

Each new version was created using copy-then-modify per CONTRIBUTING.md.

Image pinning

Two tasks had hardcoded mutable UBI8 images. Both pinned with digests already resolved via skopeo inspect:

  • gitlab-add-label: registry.access.redhat.com/ubi8/ubi:8.2 → pinned with @sha256:d748c21a55796827da82c61f162b505c59451cba24f1874e5185f21275b6bddc
  • create-gitlab-release: registry.access.redhat.com/ubi8/ubi-minimal:8.2 → pinned with @sha256:5cfbaf45ca96806917830c183e9f37df2e913b187aadb32e89fd83fa455ebaa6
  • git-rebase, git-version, scorecard: images already pinned by sha256 digest
  • git-cli, gitea-set-status, gitlab-set-status: image provided via task params

Why gitlab-set-status jumps to 0.4

PR #1324 (open since 2024, needs-ok-to-test) also creates a gitlab-set-status/0.3. That PR adds SSL verification options — a different change from the API bump done here. To avoid a version collision, this PR creates 0.4 directly, skipping 0.3. If #1324 merges at some point, 0.3 would carry its SSL fix on v1beta1, while 0.4 carries the v1 bump. No conflict either way.

Additional changes

  • Tests: git-cli, git-version, gitea-set-status, and gitlab-set-status test manifests bumped to v1
  • Samples: git-rebase (Pipeline + PipelineRun) and create-gitlab-release samples bumped to v1
  • git-rebase PipelineRun: spec.serviceAccountName moved to spec.taskRunTemplate.serviceAccountName per Tekton v1 API
  • Test fixtures: gitea-set-status and gitlab-set-status both have tests/fixtures/ directories with mock HTTP responses — preserved as-is (no Tekton apiVersions inside)

Validation

  • Zero remaining v1beta1 references across all 8 new version directories (31 files)
  • File count matches between old and new versions for every task
  • Semantic diff confirms only expected fields changed in task YAMLs (plus the two UBI8 image pins)
  • Original versions untouched
  • Single commit, DCO signed

Note on pre-existing conditions

git-cli, git-rebase, gitea-set-status, gitlab-add-label, gitlab-set-status, create-gitlab-release, and scorecard interpolate $(params.*) directly in script: blocks.
These patterns are inherited from previous versions and not introduced by this PR.
Script injection hardening will be addressed in a separate batch as part of #1381.

Ref: #1381

/kind cleanup

Submitter Checklist

Bumps apiVersion from tekton.dev/v1beta1 to tekton.dev/v1 for:
git-cli (0.4 → 0.5), git-rebase (0.1 → 0.2),
git-version (0.1 → 0.2), gitea-set-status (0.1 → 0.2),
gitlab-add-label (0.1 → 0.2), gitlab-set-status (0.2 → 0.4),
create-gitlab-release (0.1 → 0.2), scorecard (0.1 → 0.2).

Each new version was created using copy-then-modify per CONTRIBUTING.md.
gitlab-add-label: pinned ubi8/ubi:8.2 image with sha256 digest.
create-gitlab-release: pinned ubi8/ubi-minimal:8.2 image with sha256 digest.
git-rebase: PipelineRun sample serviceAccountName moved to
spec.taskRunTemplate.serviceAccountName per Tekton v1 API.
gitlab-set-status: bumped to 0.4 (skipping 0.3) to avoid version
collision with open PR tektoncd#1324 which also creates 0.3.

Ref: tektoncd#1381

Signed-off-by: gferreir <guilherme.nmf@gmail.com>
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 25, 2026
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 25, 2026
@gferreir

Copy link
Copy Markdown
Contributor Author

/assign @vdemeester

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2026
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2026
@tekton-robot
tekton-robot merged commit 112374c into tektoncd:main Oct 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants