Skip to content

chore(linters-a): bump apiVersion v1beta1 → v1 for 9 code quality tasks - #1405

Open
gferreir wants to merge 1 commit into
tektoncd:mainfrom
gferreir:chore/linters-a-api-v1-bump
Open

gferreir wants to merge 1 commit into
tektoncd:mainfrom
gferreir:chore/linters-a-api-v1-bump

Conversation

@gferreir

Copy link
Copy Markdown
Contributor

Changes

API version bump for 9 code quality and linting tasks, continuing the v1beta1 → v1 migration tracked in #1381. This is the last PR in the batch — all 121 tasks from the issue are now covered.

Tasks updated

Task Old → New Changes
ai-code-review 0.1 → 0.2 apiVersion v1, minVersion 0.50.0, image pinned (×2 steps)
black 0.2 → 0.3 apiVersion v1, minVersion 0.50.0
check-make 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
datree 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
flake8 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
golangci-lint 0.2 → 0.3 apiVersion v1, minVersion 0.50.0
hadolint 0.1 → 0.2 apiVersion v1, minVersion 0.50.0
kube-linter 0.1 → 0.2 apiVersion v1, minVersion 0.50.0, image pinned
kubeval 0.1 → 0.2 apiVersion v1, minVersion 0.50.0

Each new version was created using copy-then-modify per CONTRIBUTING.md.

Image pinning

  • ai-code-review: docker.io/library/python:3.12-slim was used in both steps without a digest. Pinned both with @sha256:2f17fc044b579bab302c2e8054d3a686e2cb9a83de48e70534b94cd8ebbe06a9
  • kube-linter step fetch-and-setup: registry.access.redhat.com/ubi8/ubi-minimal:8.2 → pinned with @sha256:5cfbaf45ca96806917830c183e9f37df2e913b187aadb32e89fd83fa455ebaa6. The second step (lint) already had stackrox/kube-linter pinned by digest.
  • check-make, hadolint, kubeval: images already pinned by sha256 digest
  • black, flake8, datree: image provided via task params
  • golangci-lint: image tag built from $(params.version) — not pinnable

Additional changes

  • Tests: black, check-make, flake8, golangci-lint, hadolint, and kube-linter test manifests bumped to v1
  • Samples: ai-code-review, datree (2 samples), and kube-linter (4 samples) bumped to v1

Validation

  • Zero remaining v1beta1 references across all 9 new version directories (41 files)
  • File count matches between old and new versions for every task
  • Semantic diff confirms only expected fields changed in task YAMLs (plus the 3 image pins)
  • Original versions untouched
  • Single commit, DCO signed

Note on pre-existing conditions

ai-code-review, golangci-lint, kube-linter, and flake8 interpolate $(params.*) directly in script: blocks.
These patterns are inherited from previous versions and not introduced by this PR.
Script injection hardening will be addressed in a separate batch as part of #1381.

Ref: #1381

/kind cleanup

Submitter Checklist

Bumps apiVersion from tekton.dev/v1beta1 to tekton.dev/v1 for:
ai-code-review (0.1 → 0.2), black (0.2 → 0.3),
check-make (0.1 → 0.2), datree (0.1 → 0.2),
flake8 (0.1 → 0.2), golangci-lint (0.2 → 0.3),
hadolint (0.1 → 0.2), kube-linter (0.1 → 0.2),
kubeval (0.1 → 0.2).

Each new version was created using copy-then-modify per CONTRIBUTING.md.
ai-code-review: pinned python:3.12-slim image with sha256 digest (both steps).
kube-linter: pinned ubi8/ubi-minimal:8.2 image with sha256 digest.

Ref: tektoncd#1381

Signed-off-by: gferreir <guilherme.nmf@gmail.com>
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 25, 2026
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 25, 2026
@gferreir

Copy link
Copy Markdown
Contributor Author

/assign @vdemeester

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants