Expose value-picking sliders as a slider and a radio group - #31191
Open
rezabakhshilaktasaraei wants to merge 4 commits into
Open
Expose value-picking sliders as a slider and a radio group#31191rezabakhshilaktasaraei wants to merge 4 commits into
rezabakhshilaktasaraei wants to merge 4 commits into
Conversation
The sections of Ui::DiscreteSlider are painted, so screen readers had nothing to focus or read. In screen reader mode the slider becomes a Tab stop reporting a tab control with a virtual tab per section: Tab lands on the active tab, the arrows and Home/End switch to the tab they land on right away, like the native Windows tab controls, and the platform announces the switch through the focus move. The selection interface carries the selected state, and subclasses can follow the browse position through a producer and an accessor. Without a screen reader nothing changes - the widget is not focusable then.
The notifications count strip picks a number, not a displayed section, so a screen reader hears it as a single slider element now: the arrows change the value right away and the value is reported both numerically for the range pattern and as text, which is what a screen reader reads and announces.
rezabakhshilaktasaraei
force-pushed
the
discrete-slider-value-roles
branch
from
August 28, 2026 01:54
1a560b5 to
9d27388
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the DiscreteSlider strips do not switch displayed content - they pick a value - so with #31097 in place they can get their real roles:
All other strips keep the tab roles from #31097.
Depends on #31097 and on desktop-app/lib_ui#354 (the accessible value interface), so it compiles only on top of them.