Repository navigation
fix: preserve the page port in WebSocket URLs - #25
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoPreserve the page port in WebSocket URLs
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded browser page builds its WebSocket URL with
location.hostname, which omits an explicit port. Opening the documented local server athttp://localhost:18080therefore triesws://localhost/wsinstead of the same server port.Use
location.hostin both HTTP and HTTPS branches. This two-line change preserves the current page's port, including IPv6 hosts, while retaining the existing/wspath.Validation: six offline cases execute the actual HTML inline configuration. The original fails four cases; the patch and an independently applied patch copy both pass all six (HTTP/HTTPS, explicit/default ports, IPv4/IPv6). Source blob and branch SHA verified before publication.
Scope: URL compatibility only. No Go build, actual browser/microphone, provider calls or end-to-end service validation was possible. The broader repository review remains explicitly limited; this draft does not establish a full or security audit pass.