Generate consistent JSON between get and list commands - #116
Merged
Merged
Conversation
jeri-temporal
had a problem deploying
to
integration
September 28, 2026 21:21 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Get commands just print the resulting protojson, whereas list commands wrap a list of protos in a struct providing additional context. When that struct is rendered as JSON, the protos within get handled as regular structs. Using jsonv2 allows us to set a custom marshaller that delegates proto messages to protojson
jeri-temporal
force-pushed
the
jeri/json-consistency
branch
from
September 28, 2026 23:44
8481a48 to
a960f77
Compare
anekkanti
approved these changes
Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get commands just print the resulting protojson, whereas list commands wrap a list of protos in a struct providing additional context. When that struct is rendered as JSON, the protos within get handled as regular structs. Using jsonv2 allows us to set a custom marshaller that delegates proto messages to protojson
What was changed
Switch to jsonv2 in the printer+ add a custom marshaller for protos. This serializes protos the same whether they're nested or not.
Why?
Consistency between
listandgetcommands when printing the same protosChecklist
Closes [Bug] List/Get API keys have different outputs cli#1200
How was this tested:
make test, verified no diff between the output of./temporal-cloud apikey list -o json | jq '.ApiKeys[0]'and./temporal-cloud apikey get --key-id <ID from list output>