Repository navigation
Skip activity API types when generating the 1.22 UTF-8 repair - #305
Merged
Merged
Conversation
The standalone activity types (temporal.api.activity.v1) came in with a later API version and have no counterpart in the 1.22 protos. The generator did not filter them, so `make genvisitor` emitted cases that import proto/1_22/api/activity/v1, a package that does not exist, and the build broke. That is likely why repair_utf8_gen.go had not been regenerated since it was added. Filtering the package brings the output back in line with the checked-in file, which is unchanged. The new test runs the generator the way `make genvisitor` does and compares the result with the checked-in file, so the next dependency upgrade that changes or breaks the output fails in CI instead of surprising whoever regenerates next.
hehaifengcn
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone activity types (temporal.api.activity.v1) came in with a later API version and have no counterpart in the 1.22 protos. The generator didn't filter them, so
make genvisitoremitted cases that import proto/1_22/api/activity/v1, a package that doesn't exist, and the build broke. That is likely why repair_utf8_gen.go had not been regenerated since it was added.Filtering the package brings the output back in line with the checked-in file, which is unchanged.
The new test runs the generator the way
make genvisitordoes and compares the result with the checked-in file, so the next dependency upgrade that changes or breaks the output fails in CI instead of surprising whoever regenerates next.