Repository navigation
Conversation
leizor
force-pushed
the
leizor/missing-xfered-bytes-readat
branch
from
September 16, 2026 20:40
a62b02a to
526ce87
Compare
Author
|
|
leizor
marked this pull request as ready for review
September 16, 2026 21:19
leizor
force-pushed
the
leizor/missing-xfered-bytes-readat
branch
from
September 17, 2026 23:02
526ce87 to
ca4f1ec
Compare
leizor
marked this pull request as draft
September 17, 2026 23:46
leizor
force-pushed
the
leizor/missing-xfered-bytes-readat
branch
6 times, most recently
from
September 21, 2026 19:58
61b6399 to
431a41f
Compare
leizor
marked this pull request as ready for review
September 21, 2026 21:01
fpetkovski
reviewed
Sep 29, 2026
| readBytes: 0, | ||
| } | ||
|
|
||
| trc.readAtTracker = newReadAtTracker(isFailureExpected) |
Contributor
There was a problem hiding this comment.
Won't this affect all operations, including Get and GetRange? We would be creating a mutex and a map per per bucket read which potentially is a significant performance regression.
Perhaps we can instantiate the specialized read tracker only for the Upload operation.
fpetkovski
approved these changes
Oct 2, 2026
leizor
force-pushed
the
leizor/missing-xfered-bytes-readat
branch
3 times, most recently
from
October 5, 2026 16:18
2e01b37 to
770bfe5
Compare
when the underlying reader is read via io.ReaderAt Signed-off-by: Justin Lei <lei.justin@gmail.com>
Signed-off-by: Justin Lei <lei.justin@gmail.com>
leizor
force-pushed
the
leizor/missing-xfered-bytes-readat
branch
from
October 8, 2026 21:06
770bfe5 to
143bc9f
Compare
Author
|
@fpetkovski Are you waiting on anything from me to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rded when the underlying reader is read via
io.ReaderAtChanges
timingReaderSeekerReaderAt.ReadAtnow updates metrics so theobjstore_bucket_operation_transferred_bytesrecords correctly. This fixes the metric for multipart uploads, which currently always only records 0.Verification
Added two tests:
TestMetricBucket_Upload_ReadAtTestTimingReader_ConcurrentReadAtI've also run this code in a dev environment I have.