Repository navigation
Upgrade to Go 1.25 - #288
Merged
Merged
Conversation
Bump the go directive and the CI toolchain to Go 1.25 so tests can use testing/synctest. Signed-off-by: Yuchen Wang <yw3642@gmail.com>
Signed-off-by: Yuchen Wang <yw3642@gmail.com>
1 of 2 tasks
GiedriusS
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade the module and CI to Go 1.25:
go.mod:go 1.24.0→go 1.25.0.go-version(used by CI):1.24.x→1.25.xGo 1.25 ships
testing/synctest, which was requested in #287 (comment) to make time-dependent tests deterministic instead of relying ontime.Sleep. #287 will be rebased onto this change and switched to synctest.Go 1.24 is no longer supported upstream, so raising the minimum Go version for importers should be low-risk. No dependency versions change (
go mod tidyis a no-op).Verification
With Go 1.25.8:
go build ./...andgo vet ./...pass.make test-localpasses exceptTestSSECencryption, which fails the same way onmainbecause the pinned MinIO image can no longer be pulled from Docker Hub (fixed separately in s3: fix goroutine leak when Iter stops early #287)..bingo) builds and runs under Go 1.25. The only finding is a pre-existing goimports issue inscripts/cfggen/main.go, whichmainalso reports with Go 1.24.