Skip to content

s3: fix SignatureV2 not applying - #290

Open
andyasp wants to merge 1 commit into
thanos-io:mainfrom
andyasp:aasp/s3-signature-v2
Open

andyasp wants to merge 1 commit into
thanos-io:mainfrom
andyasp:aasp/s3-signature-v2

Conversation

@andyasp

@andyasp andyasp commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

In the configuration for S3 using AWS SigV2 can be specified:

type: S3
config:
  ...
  signature_version2: true

The reason for this change is that even when signature_version2 is true, SigV4 is used.

overrideSignerType tried to hook into the credential chain in order apply the SigV2 configuration, but only implemented Retrieve(), which is no longer called by minio-go and marked as deprecated (code reference). If you step through the request initiation RetrieveWithCredContext is now called, so this change implements that method for overrideSignerType for the hook to work again.

Verification

Unit test that fails without the change and passes with it.

Signed-off-by: Andy Asp <andy.asp@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant