Repository navigation
Conversation
Signed-off-by: Andy Asp <andy.asp@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In the configuration for S3 using AWS SigV2 can be specified:
The reason for this change is that even when
signature_version2istrue, SigV4 is used.overrideSignerTypetried to hook into the credential chain in order apply the SigV2 configuration, but only implementedRetrieve(), which is no longer called byminio-goand marked as deprecated (code reference). If you step through the request initiationRetrieveWithCredContextis now called, so this change implements that method foroverrideSignerTypefor the hook to work again.Verification
Unit test that fails without the change and passes with it.