Repository navigation
Conversation
The connection string already carries the account name, so only require storage_account when storage_connection_string is not set. Fixes thanos-io#90 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
When
storage_connection_stringis set, the Azure bucket is created from the connection string alone, which already contains the account name. Validation still demandedstorage_accountthough, so the account name had to be given twice (see the report on the issue).storage_accountis now only required when no connection string is configured. The error message says so, and the README notes that it does not have to be set with a connection string.Tests: added a
Connection string without storage accountcase to the Azure config table; the existing "Missing storage account" case still fails validation.go test ./providers/azure/passes. A CHANGELOG entry is included.