Repository navigation
Conversation
Avoid memory leaks. ServiceContainer ready. Transformer interfaces.
Contributor
|
Closing this in favor of #582 I think there's a lot in here we'd benefit from considering, but I feel like we need to get the current state of things out as a v1 and work on some of the more radical changes like splitting things into usable traits in a v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on increasing fractal performance in lognrunning application.
Not to setCurrentScope
First step is to make
Transformerimmutable. We must not set current scope to Transformer. This will give us opportunity to store transformers in service container. Scope should be passed to eachtransformorincludeSomethingmethod as argument.TransformerAbstract should be removed.
User must construct his own Transformer class.
Now TransformerAbstract looks like
For example User can make he`s own lightweight Transformer without includes. It will be a little faster because we do not spend time on figure out what to include.
Any mention of TransformerAbstract has been removed from Scope.
Also