docs(portal): fix syntax and compilation errors in v5 guide snippets - #8854
docs(portal): fix syntax and compilation errors in v5 guide snippets#8854TanmayDagur wants to merge 1 commit into
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated TypeScript v5 MDX examples for Auth configuration, in-app wallet connection, and wallet balance retrieval. ChangesTypeScript v5 documentation examples
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
docs(portal): fix syntax and compilation errors in v5 guide snippets
What
This PR fixes critical syntax and compilation errors in the code examples on the Getting Started and Auth landing pages in the documentation portal.
Why
Currently, copying and pasting the official snippets results in direct compilation or runtime errors:
getting-started/page.mdxreferenced an undefinedTEST_CLIENTvariable and passed an invalid type togetWalletBalance(missingclientparameter and passingaccountinstead ofaddress).auth/page.mdxcontained a syntax error (semicolon inside an object literal) and used an undefinedclientvariable (should bethirdwebClient).Changes
getting-started/page.mdxwallet connect example andgetWalletBalancesignature.clienttothirdwebClientinauth/page.mdx.PR-Codex overview
This PR focuses on updating the authentication and wallet connection logic in the application, ensuring that the correct client and parameters are used for creating the
thirdwebClientand fetching wallet balances.Detailed summary
thirdwebClientto use a comma instead of a semicolon.adminAccountparameter increateAuthto usethirdwebClient.clientvariable directly.getWalletBalancecall to includeaddress: account.address.Summary by CodeRabbit