allow managed rotation as an option

[0xFirekeeper]

PR-Codex overview

This PR focuses on enhancing the RotateAdminKeyButton component by adding functionality for managing a vault with an optional project secret key, improving user feedback regarding the vault's management status.

Detailed summary

• Added Input for project secret key.
• Introduced stayManaged state to track vault management preference.
• Updated mutation to conditionally include projectSecretKey.
• Enhanced UI feedback for managed and unmanaged vaults.
• Added validation messages for missing secret key.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

• New Features
  • Added an option to keep a vault managed when rotating its admin key.
  • Added a project secret key entry to re-encrypt the rotated admin key and access token when keeping the vault managed.
  • Updated the rotation modal UI and confirmation button behavior, including conditional messaging and disabling until a secret key is provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d2dc514

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
thirdweb-www	Ready	Preview, Comment	Jul 29, 2026 4:23am

4 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs-v2	Skipped		Jul 29, 2026 4:23am
nebula	Skipped		Jul 29, 2026 4:23am
thirdweb_playground	Skipped		Jul 29, 2026 4:23am
wallet-ui	Skipped		Jul 29, 2026 4:23am

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2a63f3aa-b32c-4711-9d9f-60ba5453a18b

📥 Commits

Reviewing files that changed from the base of the PR and between 021bd5c and d2dc514.

📒 Files selected for processing (1)

• apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

Walkthrough

The admin key rotation modal now lets managed vaults remain managed by accepting a project secret key. State, mutation arguments, trigger presentation, checkbox behavior, secret-key input, validation, and warning text were updated.

Changes

Managed vault rotation

Layer / File(s)	Summary
Rotation state and mutation apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx	Tracks managed-vault selection and secret-key input, passing projectSecretKey only when the vault remains managed and the input is non-empty.
Rotation controls and modal apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx	Adds the managed-vault checkbox and conditional password input, clears input when unchecked, updates warning text and trigger presentation, and disables confirmation when a required secret key is missing.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: making managed vault rotation an option.
Description check	✅ Passed	The description is detailed and covers the feature and implementation, though it omits the template's Notes for reviewer and How to test sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch firekeeper/managed

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@apps/dashboard/src/app/`(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx:
- Around line 42-52: Update the submission flow around rotateAdminKeyMutation
and its trigger so that when stayManaged is true but willStayManaged is false,
rotation is blocked and validation is shown for the missing secret key. Preserve
the existing behavior of passing the trimmed key when provided and omitting it
only when managed mode is not selected.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33768ab4-7fa6-4424-8cfb-b3d589d53084

📥 Commits

Reviewing files that changed from the base of the PR and between 8c521aa and 021bd5c.

📒 Files selected for processing (1)

• apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/vault/components/rotate-admin-key.client.tsx

[github-actions]

size-limit report 📦

Path	Size
@thirdweb-dev/nexus (esm)	105.66 KB (0%)
@thirdweb-dev/nexus (cjs)	319.47 KB (0%)