Skip to content

fix: SEGFAULT when player moves in Below The Surface - #257

Closed
kottochii wants to merge 3 commits into
thoth-tech:mainfrom
kottochii:belowthesurface-segfault
Closed

kottochii wants to merge 3 commits into
thoth-tech:mainfrom
kottochii:belowthesurface-segfault

Conversation

@kottochii

Copy link
Copy Markdown
Collaborator

Description

Below The Surface was crashing immediately after starting due to the game using deleted variables immediately after the deletion.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The game has been played up to level 2 without crashes.

Testing Checklist

  • Tested in latest SplashKit
  • Note: in order to test, the pull request fix: resolve C++ build errors in games #254 has to be merged, otherwise the latest SplashKit will be raising errors due to changes in the documentation

@ayushindapure ayushindapure left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good readability, 'else if' conditions make the intended priority/order of player actions very clearer than before.

@kottochii

Copy link
Copy Markdown
Collaborator Author

Closed as duplicate of #247

@kottochii kottochii closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants