Repository navigation
VentureAdventure: Addition of dynamic controls & addition of support for arcade controller - #258
Conversation
Rhinoatron
left a comment
Rhinoatron
left a comment
There was a problem hiding this comment.
Great work. The change is focused and the dynamic control setup looks reasonable. The PR replaces the hardcoded movement, reset, start, and exit keys with a key_list_t control mapping, and the --arcade-controller-required option switches the game over to arcade-machine style controls. That fits the stated goal of supporting arcade machine controls while keeping the default keyboard controls available. I also checked for duplicate PRs covering the same VentureAdventure dynamic-controls / arcade-controller support and did not find any. Approved
jankiluitel
left a comment
jankiluitel
left a comment
There was a problem hiding this comment.
Reviewed the dynamic control mapping and arcade-controller support for VentureAdventure. The new key_list_t approach cleanly replaces the previously hardcoded movement, reset, start, and exit keys while preserving the default keyboard controls.
The --arcade-controller-required option also provides a clear way to switch to the arcade-machine control mapping, and the updates are consistently applied throughout the game flow.
Everything looks good from my side. Approved! ✅
Description
In order to add support in the Arcade Machine, the key sets were made dynamic. In addition to that, with the usage of
--arcade-controller-requiredoption when starting the game, the user may control it from Arcade Machine controls.Type of change
How Has This Been Tested?
Was tested on Linux machine, with other PRs applied.