[sepcnt]

Split assumption preservation out of #3265 for independent review.

Let $P$ be an assumption predicate and $\Gamma$ the current analyzer context. Simplifying $P$ to $\mathrm{true}$ establishes

$$ \Gamma \models P, $$

which does not imply unconditional validity, $\models P$. A later pass may use a different context $\Gamma'$ for which

$$ \Gamma' \not\models P. $$

Replacing $\mathrm{assume}(P)$ with $\mathrm{assume}(\mathrm{true})$ discards the explicit predicate that later passes could otherwise use.

Keep the original predicate when it simplifies to true. Other simplification results remain unchanged.

In the regression, the analyzer derives $n \ge 0$ from the buffer shape. This still allows

$$ \min(0,n)=0, $$

while preserving the explicit $\mathrm{assume}(n \ge 0)$ annotation.

Summary

• Preserve the original tl.assume predicate when the current analyzer simplifies it to true. Other simplification results remain unchanged.
• Extend test_buffer_shape_constraint to check that assume(n >= 0) remains explicit while min(0, n) simplifies to 0.

C++ style / lint notes

• The PR changes C++, but the available evidence does not show changes to rules documented in docs/developer_guide/cpp_style.md.
• CI runs the C++ API Style Audit (warning only). No audit results were provided.

Tests

• Test execution results were not provided.

[github-actions]

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Source mode: Auto
• Repository: tile-ai/tilelang
• Branch: main
• File: .coderabbit.yaml
• Commit: fe8c346
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 08d67c3d-5c6a-4716-9006-2d235254fc74

📥 Commits

Reviewing files that changed from the base of the PR and between d99a7f3 and a6f944e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: tile-ai/tilelang
• Branch: main
• File: .coderabbit.yaml
• Commit: 741bf8b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 85bd0a0a-02c2-4c5e-a673-33fd39644524

📥 Commits

Reviewing files that changed from the base of the PR and between 741bf8b and 95e3394.

📒 Files selected for processing: 2

• src/transform/simplify.cc
• testing/python/transform/test_tilelang_transform_simplify.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

The simplifier now leaves a tl.assume node unchanged when its simplified predicate is constant one. The regression test checks that the assumption n >= 0 allows the store index to simplify to 0.

Changes: Assumption simplification

Layer / File(s)	Summary
Preserve constant assumptions and test simplification src/transform/simplify.cc, testing/python/transform/test_tilelang_transform_simplify.py	The simplifier updates the tl.assume attribute only when the simplified predicate is not constant one. The test adds n >= 0 to both functions and expects the store index to be 0.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: bug, arith

Suggested reviewers: siriusneo

Merge Risk: ⚪ Minimal · up to 95e33

No actionable merge risk was identified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preserving tl.assume predicates that simplify to true.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[KellyFrog]

LGTM